----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60155 -----------------------------------------------------------
Ship it! Nice improvement. src/declarativeimports/calendar/calendar.cpp <https://git.reviewboard.kde.org/r/118668/#comment41906> Don't forget to remove these debugs before committing. - Sebastian Kügler On June 11, 2014, 2:55 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118668/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 2:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Basically splits the Calendar::m_startDate into 'today' and 'displayedDate', > where displayedDate is the date that is displayed (it controls the days model > etc) and can be manipulated by the user by eg. changing months in the > plasmoid, and today is the current day, populated by our dataengine (which > means it auto-updates with no need for a timer). This allows for greater > flexibility and things like "Go back to today" when eg. the plasmoid is > hidden or when the user have browsed too far in the calendar and just wants > to get back to today (the button to do that pending). Also this fixes a > problem where the time dataengine is being polled every 30secs for the clock > and would reset the calendar view as the startDate is currently bound to the > dataengine and the view resets on that change. > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.h fd2c534 > src/declarativeimports/calendar/calendar.cpp 4225579 > src/declarativeimports/calendar/qml/MonthMenu.qml 89e9dc2 > src/declarativeimports/calendar/qml/MonthView.qml eee850d > > Diff: https://git.reviewboard.kde.org/r/118668/diff/ > > > Testing > ------- > > All works properly > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
