> On June 15, 2014, 8:08 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml, line 57 > > <https://git.reviewboard.kde.org/r/118769/diff/1/?file=281579#file281579line57> > > > > I'm not 100% sure this will still work as now the rotation property > > isn't being updated. > > > > From the docs: > > "The value of the QML property will be updated after the animation has > > finished. The property is not updated while the animation is running." > > > > > > We're doing this when the animation changes, which is a documentation > > grey area. I think it will be OK, but I'd like you to check before shipping. > > > > Start the animation then pause + start and check it resumes from the > > same place.
Finished probably also meaning whenever it stops. Nonetheless I played around with the running property and the rotation continues exactly where it stopped. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/#review60134 ----------------------------------------------------------- On June 15, 2014, 7:19 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118769/ > ----------------------------------------------------------- > > (Updated June 15, 2014, 7:19 p.m.) > > > Review request for Plasma, David Edmundson, Elias Probst, and Jan Grulich. > > > Bugs: 311799 and 336274 > http://bugs.kde.org/show_bug.cgi?id=311799 > http://bugs.kde.org/show_bug.cgi?id=336274 > > > Repository: plasma-framework > > > Description > ------- > > Use RotationAnimator [1] for the BusyIndicator animation which operates > directly on the scenegraph. > > This helped reducing the massive plasmashell CPU usage during file copying > (ie. notifications spinning). The results varied greatly but it can't hurt to > use the Animator nonetheless since it doesn't propagate the new rotation > angle constantly. > > [1] http://qt-project.org/doc/qt-5/qml-qtquick-rotationanimator.html > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml fafd031 > > Diff: https://git.reviewboard.kde.org/r/118769/diff/ > > > Testing > ------- > > Put notification in panel and systray, requested a view from JobViewServer, > ran top. Tried with different configurations, such as LIBGL_ALWAYS_SOFTWARE=1 > or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a > CPU relief. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
