Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 30, 2014, 11:42 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58836 --- Looks like there are still quite a few Title Case labels in th

Re: Ship with Aurorae and Qtcurve or not...

On Fri, May 30, 2014 at 6:44 AM, Sebastian Kügler wrote: > On Thursday, May 29, 2014 15:09:33 Marco Martin wrote: > > just to give a shot on every and single options, i gave a try to > modifying > > oxygen in order to make it look like breeze (therefore sharing all the > > things that it does tha

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review58830 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 30, 2014, 3:

Review Request 118428: Drop configuration options for taskbar and desktop fonts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58827 --- Shouldn't this rather use qCDebug() so that the output can be

Jenkins build is back to stable : plasma-workspace_master_qt5 #318

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #317

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 30, 2014, 2:19 p.m.) Review request for Plasma, Solid and KD

Re: Review Request 118390: Powerdevil KCM Updates

> On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: > > File Attachment: Energy Saving page after - > > powerdevil-kcm-profiles-after.png > > > > > > Why remove the icons? They make the individual settings recognizable > > more quickl

Re: Review Request 118357: Disable the agenda part of the calendar

> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted out of commenting it as that would

Re: Review Request 118357: Disable the agenda part of the calendar

> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted out of commenting it as that would

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On May 30, 2014, 1:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 140 > > > > > > we lose fast mode here. > > I think this means if I drag a 100Gb file from the internet onto > > klipper

Re: Review Request 118390: Powerdevil KCM Updates

On Friday 30 May 2014 15:34:27 Sebastian Kügler wrote: > I'll not change to groupboxes in this review, but anticipate the HIG > catching up. :) Yes, that's okay. We'll discuss the grouping HIG on our list. If we come out with a different solution to what you implemented in the end, we'll notify y

Re: Ship with Aurorae and Qtcurve or not...

On Thursday, May 29, 2014 15:09:33 Marco Martin wrote: > On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: > > Ok so after the feedback from the Beta Release an issue that we knew was > > coming have happened. Visuals being the most easily accessible bit of > > anything technical, people have

Re: Review Request 118390: Powerdevil KCM Updates

Hey, First, thanks all for the reviews. On Thursday, May 29, 2014 16:10:19 Andrew Lake wrote: > > On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: > > > Good improvements in general! > > > There are two changes which are not HIG-compliant: > > > - Control labels which are written next to the co

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 3:38 p.m.) Review request for Plasma. Changes --

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On May 30, 2014, 3:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 147 > > > > > > this comment doesn't seem true, we explicitly check if the mimetype is > > html I read this comment differen

Re: Review Request 118357: Disable the agenda part of the calendar

> On May 30, 2014, 3:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. I specifically opted out of commenting it as that would mean commenting stuff all around

Re: Review Request 118424: [klipper] Port away from KSessionManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- (Updated May 30, 2014, 1:29 p.m.) Status -- This change has been mar

Re: Review Request 118424: [klipper] Port away from KSessionManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/#review58810 --- This review has been submitted with commit 8904a2ee625d482c76

Re: Review Request 118424: [klipper] Port away from KSessionManager

> On May 30, 2014, 3:21 p.m., David Edmundson wrote: > > Current behaviour is if you have something in your clipboard on closing, it > > will be there when you restart. > > Can you confirm this still works before shipping. sure, steps done: 1. recompiled and installed klipper 2. stopped running

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- Ship it! Since the visible flag is now static false, let's co

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

> On May 30, 2014, 3:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 140 > > > > > > we lose fast mode here. > > I think this means if I drag a 100Gb file from the internet onto > > klipper

Re: Review Request 118424: [klipper] Port away from KSessionManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/#review58805 --- Ship it! Current behaviour is if you have something in your c

Review Request 118424: [klipper] Port away from KSessionManager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58804 --- klipper/urlgrabber.cpp

Re: Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 --- klipper/urlgrabber.cpp

Re: Review Request 118357: Disable the agenda part of the calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58803 --- Ship it! Ship it since the changes look sane to me. Mind you,

Review Request 118423: [klipper] Port KMimeType to QMimeType

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/#review58799 --- This review has been submitted with commit a9b649e53d5614d8d7

Re: Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/ --- (Updated May 30, 2014, 12:51 p.m.) Status -- This change has been ma

Re: Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/#review58798 --- Ship it! Ship It! - Martin Klapetek On May 30, 2014, 2:45

Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/#review58796 --- This review has been submitted with commit 2363d463b4f2496714

Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- (Updated May 30, 2014, 12:12 p.m.) Status -- This change has been ma

Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/#review58795 --- Ship it! Ship It! - Marco Martin On May 30, 2014, 12:01 p.

Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Re: Review Request 118413: Put the settings views in a ScrollView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- (Updated May 30, 2014, 10:52 a.m.) Status -- This change has been ma

Re: Review Request 118413: Put the settings views in a ScrollView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/#review58786 --- This review has been submitted with commit 69c55fbc6dcf1d074f

Re: Review Request 118413: Put the settings views in a ScrollView

> On May 30, 2014, 10:42 a.m., David Edmundson wrote: > > desktoppackage/contents/configuration/AppletConfiguration.qml, line 224 > > > > > > is large/2 not just "small" ? I have no idea, this was already there

Re: Review Request 118413: Put the settings views in a ScrollView

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/#review58778 --- Ship it! desktoppackage/contents/configuration/AppletConfigu

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 10:29 a.m.) Status -- This change has been ma

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58780 --- This review has been submitted with commit a0b58e066ce2f48a8f

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58779 --- Ship it! Ship It! - Marco Martin On May 30, 2014, 10:22 a.

Review Request 118417: [klipper] Port from KDebug to QDebug

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/#review58772 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 30, 2014, 6: