> On May 30, 2014, 1:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 140 > > <https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line140> > > > > we lose fast mode here. > > I think this means if I drag a 100Gb file from the internet onto > > klipper it will start downloading it. > > > > Not sure how problematic this is. > > Martin Gräßlin wrote: > given the documentation that should be fine, see > http://qt-project.org/doc/qt-5/qmimedatabase.html#mimeTypeForUrl > > my interpretation of the documentation is that it won't download
Yes, it won't download, it will just return a default mimetype, which is actually pretty bad... > On May 30, 2014, 1:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 147 > > <https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147> > > > > this comment doesn't seem true, we explicitly check if the mimetype is > > html > > Martin Gräßlin wrote: > I read this comment different: if clipboard contents starts with http, > enforce the mimetype to be html, because that's what's being done in the if Yep, it's just ensuring it's html if it's http. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 ----------------------------------------------------------- On May 30, 2014, 1:38 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118423/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 1:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [klipper] Port KMimeType to QMimeType > > > Diffs > ----- > > klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 > > Diff: https://git.reviewboard.kde.org/r/118423/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
