----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 -----------------------------------------------------------
klipper/urlgrabber.cpp <https://git.reviewboard.kde.org/r/118423/#comment40905> we lose fast mode here. I think this means if I drag a 100Gb file from the internet onto klipper it will start downloading it. Not sure how problematic this is. klipper/urlgrabber.cpp <https://git.reviewboard.kde.org/r/118423/#comment40906> this comment doesn't seem true, we explicitly check if the mimetype is html klipper/urlgrabber.cpp <https://git.reviewboard.kde.org/r/118423/#comment40907> this can definitely be QMimeDatabase::MatchExtension as this file doesn't actually exist, we just want it to match .html to return text/html. The full mimetype match might even fail I /think/ this can also be reduced to db.mimeTypeForName("text/html"); which would be easier to read. - David Edmundson On May 30, 2014, 1:02 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118423/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 1:02 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [klipper] Port KMimeType to QMimeType > > > Diffs > ----- > > klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 > > Diff: https://git.reviewboard.kde.org/r/118423/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
