Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118199/ --- (Updated May 20, 2014, 5:26 a.m.) Status -- This change has been mar

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118199/#review58183 --- This review has been submitted with commit deea06f6097e7f412e

Jenkins build is back to normal : plasma-workspace_master_qt5 #252

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #251

See Changes: [aacid] Do not extract i18n from the tests folder -- [...truncated 1841 lines...] :362:36:

Build failed in Jenkins: plasma-workspace_master_qt5 #250

See Changes: [mail] Fix build (multiple missing Qt5:: components in target_link_libraries). -- [...truncated 1842 lines...] void Widget::setGeometry(const QRectF &geometry) ^ [ 40%]

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/ --- (Updated May 19, 2014, 8:15 p.m.) Status -- This change has been mar

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/#review58175 --- This review has been submitted with commit 7b5e47c1e761281788

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

> On May 19, 2014, 7:48 p.m., David Edmundson wrote: > > dataengines/favicons/CMakeLists.txt, line 10 > > > > > > Seems more like KF5::Plasma needs to publicly link against Qt5:Gui > > Elias Probst wrote: > W

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/#review58174 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 7:39

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

> On May 19, 2014, 7:48 p.m., David Edmundson wrote: > > runners/calculator/CMakeLists.txt, line 33 > > > > > > Why this? Sorted the list alphabetically when I wrongly placed Qt5::Gui there before and then remov

Re: Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/#review58170 --- dataengines/favicons/CMakeLists.txt

Review Request 118209: Fix build of plasma-workspace (missing Qt5 target_link_libraries).

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Jenkins build is back to normal : plasma-workspace_master_qt5 #249

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

> On May 19, 2014, 3:57 p.m., David Edmundson wrote: > > freespacenotifier/freespacenotifier.cpp, line 66 > > > > > > set it to null too > > otherwise you can crash. > > > > Personally I'd also rename

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/ --- (Updated May 19, 2014, 6:15 p.m.) Review request for Plasma. Changes --

Re: Ship with Aurorae and Qtcurve or not...

On Monday 19 May 2014, Marco Martin wrote: > On Thursday 15 May 2014, Marco Martin wrote: > > btw, i added a small kde4 application in the breeze repo in the branch > > mart/kde4breeze > > that tries to set qtcurve, apply colors etc in the kde4 session. > > Do we go in this direction? > > so, this

Build failed in Jenkins: plasma-workspace_master_qt5 #248

See Changes: [kde] Show applets from the system tray in Widget Explorer -- [...truncated 1614 lines...] from /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/qt5/inst/include

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

> On May 19, 2014, 5:57 p.m., David Edmundson wrote: > > freespacenotifier/freespacenotifier.cpp, line 35 > > > > > > is there no pretty header? Ah yes, wrong autocomplete :) > On May 19, 2014, 5:57 p.m., David

Re: Ship with Aurorae and Qtcurve or not...

On Thursday 15 May 2014, Marco Martin wrote: > > btw, i added a small kde4 application in the breeze repo in the branch > mart/kde4breeze > that tries to set qtcurve, apply colors etc in the kde4 session. > Do we go in this direction? so, this is in now. please test. one problem is: i need with

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118126/ --- (Updated May 19, 2014, 4 p.m.) Status -- This change has been marked

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118126/#review58162 --- This review has been submitted with commit 23e7bb1774e10b2a9d

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/#review58157 --- freespacenotifier/freespacenotifier.cpp

Re: Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/#review58161 --- shell/scripting/panel.cpp

Re: Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/#review58158 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 3:13 p.m

Re: Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/#review58159 --- shell/scripting/panel.cpp

Re: Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/ --- (Updated May 19, 2014, 3:19 p.m.) Status -- This change has been mar

Re: Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/#review58160 --- This review has been submitted with commit 8ee965ee87dc551ba0

Review Request 118206: Expose min/max length panel properties to desktop scripting, add bounds check and clean up length property setter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118206/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Review Request 118205: Turn the free space notifier into StatusNotifierItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118205/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: High DPI issues

On Mon, May 19, 2014 at 3:47 PM, Marco Martin wrote: > On Monday 19 May 2014, David Edmundson wrote: >> Read this before doing anything: >> http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-> >> ios-and-x11/ >> >> There are branches being merged in for 5.4. They affect QW

Re: High DPI issues

On Monday 19 May 2014, David Edmundson wrote: > Read this before doing anything: > http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-> > ios-and-x11/ > > There are branches being merged in for 5.4. They affect QWidgets too. > > Everything is based around a devicePixelRat

Re: High DPI issues

On Mon, May 19, 2014 at 2:48 PM, Teo Mrnjavac wrote: > On Monday, May 19, 2014 14:40:59 David Edmundson wrote: >> Read this before doing anything: >> http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-i >> os-and-x11/ >> >> There are branches being merged in for 5.4. They a

Review Request 118204: [klipper] Show filter widget before sending key events to it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118204/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: High DPI issues

On Monday, May 19, 2014 14:40:59 David Edmundson wrote: > Read this before doing anything: > http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-i > os-and-x11/ > > There are branches being merged in for 5.4. They affect QWidgets too. > > Everything is based around a device

Re: High DPI issues

*on a normal high DPI screen; ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: High DPI issues

Read this before doing anything: http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/ There are branches being merged in for 5.4. They affect QWidgets too. Everything is based around a devicePixelRatio. As I understand it, you write code as though you have pixel

High DPI issues

Hello list, I've done a bit of research on DPI-related issues, which become particularly evident on high-DPI displays. As far as I can tell, right now Plasma does some scaling, which is mostly based on font size and QPaintDevice::physicalDpiX(). While this is all fine, I'd like to point out two

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

> On May 19, 2014, 2:14 p.m., David Edmundson wrote: > > So between Qt4->5 there must have been ensurePolished() removed from > > QWidget. > > We restored it in QMenu, but perhaps that wasn't actually the right > > approach? > > Martin Gräßlin wrote: > no, in Qt4 QWidget destroyed the nati

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

> On May 19, 2014, 12:14 p.m., David Edmundson wrote: > > So between Qt4->5 there must have been ensurePolished() removed from > > QWidget. > > We restored it in QMenu, but perhaps that wasn't actually the right > > approach? > > Martin Gräßlin wrote: > no, in Qt4 QWidget destroyed the nat

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

> On May 19, 2014, 2:14 p.m., David Edmundson wrote: > > So between Qt4->5 there must have been ensurePolished() removed from > > QWidget. > > We restored it in QMenu, but perhaps that wasn't actually the right > > approach? no, in Qt4 QWidget destroyed the native window when one changed the f

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118199/#review58146 --- So between Qt4->5 there must have been ensurePolished() remove

Re: Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118199/#review58145 --- Ship it! Ship It! - David Edmundson On May 19, 2014, 9:49

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58144 --- This review has been submitted with commit c5c34851dc410aa146

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 12:07 p.m.) Status -- This change has been ma

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58142 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 10:56 a.

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

> On May 19, 2014, 1:06 p.m., Marco Martin wrote: > > looks fine. > > can you try it also on an item that uses dbusmenu for menus, like kmix? I just tried kmix and it looks fine to me on both left and right click. Both menus behave like I would expect (override redirect, grabbing pointer/keyboa

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 --- looks fine. can you try it also on an item that uses dbusmenu

Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k

Minutes Monday Plasma hangout

Present: Antonis, Ivan, Marco, Martin G, Sebastian, Jens, Jonathan Antonis: - Ported Plasma Active's activitymanager, almost done Ivan: - Finished resources model - Working on applications pinning to activities - Compabitibility improvements between 4 and 5 activitymanager Jens: - Ongoing discus

Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118199/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118126/#review58135 --- Ship it! Hackish, but needed. shell/widgetexplorer/widgetex

Jenkins build is back to stable : plasma-workspace_master_qt5 #244

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118198: Fix ToolTipArea.containsMouse not updating when tooltips are disabled globally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118198/#review58134 --- Commited as cfda5c4d. - Eike Hein On May 19, 2014, 8:28 a.m

Re: Review Request 118198: Fix ToolTipArea.containsMouse not updating when tooltips are disabled globally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118198/ --- (Updated May 19, 2014, 8:28 a.m.) Status -- This change has been mar

Re: Review Request 118198: Fix ToolTipArea.containsMouse not updating when tooltips are disabled globally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118198/#review58133 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 8:24 a.m

Review Request 118198: Fix ToolTipArea.containsMouse not updating when tooltips are disabled globally

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118198/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework