-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118198/#review58134
-----------------------------------------------------------


Commited as cfda5c4d.

- Eike Hein


On May 19, 2014, 8:28 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118198/
> -----------------------------------------------------------
> 
> (Updated May 19, 2014, 8:28 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> With the current code, disabling Plasma tooltips globally makes the 
> ToolTipArea.containsMouse not update. That's bad, because ToolTipAreas are 
> often in a position where they're the topmost and critical event handler, 
> since hover events aren't filterable from lower in the item hierarchy. And 
> since there's no API to access the tooltip pref from within QML, there's no 
> way to adapt to this situation either.
> 
> This patch changes the implementation so the prop always updates, and the 
> global pref just prevents tooltips from being shown.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.h c8ad886 
>   src/declarativeimports/core/tooltip.cpp 2bd0482 
> 
> Diff: https://git.reviewboard.kde.org/r/118198/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to