> On May 19, 2014, 7:48 p.m., David Edmundson wrote: > > dataengines/favicons/CMakeLists.txt, line 10 > > <https://git.reviewboard.kde.org/r/118209/diff/1/?file=273524#file273524line10> > > > > Seems more like KF5::Plasma needs to publicly link against Qt5:Gui > > Elias Probst wrote: > Will create another RR for this and then drop this.
Edit: I'm wrong I think There is a stray #include in applet.h but it won't be causing this error you were seeing. Linking here is fine too I think. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118209/#review58170 ----------------------------------------------------------- On May 19, 2014, 7:39 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118209/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 7:39 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > plasma-workspace fails to build as several components can't find Qt5 > component headers: > > 79b4614 Fix build (not finding QIcon from Qt5::Gui). > dataengines/share/CMakeLists.txt > > 32e021a Fix build (not finding QImage from Qt5::Gui). > dataengines/favicons/CMakeLists.txt > > 321445c Fix build (not finding QApplication from Qt5::Widgets). > dataengines/activities/CMakeLists.txt > > 1d34cd5 Fix build (not finding QIcon from Qt5::Gui). > runners/calculator/CMakeLists.txt > > 8a4edd3 Fix build (not finding QApplication from Qt5::Widgets). > containmentactions/paste/CMakeLists.txt > > 8dc9d9e Cleaned up indentation/trailing whitespace. > containmentactions/paste/CMakeLists.txt > > 3dc1e3e Fix build (not finding QGuiApplication from Qt5::Gui). > containmentactions/paste/CMakeLists.txt > > 39df7b3 Fix build (not finding QApplication from Qt5::Widgets). > containmentactions/switchactivity/CMakeLists.txt > > > Diffs > ----- > > containmentactions/paste/CMakeLists.txt > afcd2d4149f58ac6c92f996e8e2f3343ed914a64 > containmentactions/switchactivity/CMakeLists.txt > 90d68980af88a74c1063493393bfaece7490a770 > dataengines/activities/CMakeLists.txt > c1159e1d09be20e9f02704fddb7dbc120c3871c5 > dataengines/favicons/CMakeLists.txt > e1fa3aeb2fd97445fc1ce3992be27aba00d8a0fc > dataengines/share/CMakeLists.txt f7737bf7457d11fa8fcc3c651a172cb944239356 > runners/calculator/CMakeLists.txt 31f6fd43fe172e8d99c60a425f1ece23ff539f70 > > Diff: https://git.reviewboard.kde.org/r/118209/diff/ > > > Testing > ------- > > plasma-workspace built successfully again. > > > Thanks, > > Elias Probst > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
