Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56241 --- Is that only relevant for the legacy (XSS) locker or also for

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56240 --- would you please also adapt that for plasma-workspace repo (ne

Build failed in Jenkins: plasma-desktop_master_qt5 #56

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56219 --- Ship it! from here - see veto condition in the other RR (i do

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- (Updated April 22, 2014, 10:41 p.m.) Review request for kde-workspace and

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 10:34 p.m.) Review request for kde-workspace, Pl

Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- Review request for kde-workspace and Plasma. Bugs: 224200 http://bugs

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 9:48 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 38 > > > > > > /me would not insist on newline, but there needs to be a blank after > > the "if" > > if

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 9:56 p.m.) Review request for kde-workspace, Pla

Review Request 117691: Unload libplasma after using it in Plasma Media Center

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- Review request for Plasma and Albert Astals Cid. Repository: plasma-media

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56209 --- ksmserver/screenlocker/greeter/main.cpp

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

> On April 20, 2014, 9:18 p.m., Christoph Feck wrote: > > Can someone more familiar with the screen locker please review this, or > > suggest someone who could review it? > > Christoph Feck wrote: > Felix, could you please add Wolfgang Bauer (wbauer) and maybe Thomas > Lübking (luebking) t

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? signal() is depre

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 9:28 p.m.) Review request for kde-workspace, Pla

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117627: Let the default taskbar setting for "Show only from current screen" be false

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117627/#review56196 --- This review has been submitted with commit 5814614e9ab9495a74

Build failed in Jenkins: plasma-desktop_master_qt5 #55

See Changes: [mklapetek] Show tasks from all screens in task manager by default -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER

Re: Review Request 117627: Let the default taskbar setting for "Show only from current screen" be false

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117627/ --- (Updated April 22, 2014, 6:13 p.m.) Status -- This change has been m

Re: Review Request 117601: Improve wallpapers deduplication code a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117601/#review56195 --- This review has been submitted with commit 488d0d1e81c7c869ef

Re: Review Request 117601: Improve wallpapers deduplication code a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117601/ --- (Updated April 22, 2014, 6:11 p.m.) Status -- This change has been m

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117606: Make sure that the panel is not hidden when a plasmoid is expanded

> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56190 --- see minor nitpicks, but in general the patch seems fine and re

Build failed in Jenkins: plasma-desktop_master_qt5 #54

See Changes: [notmart] hide on focus lost -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On March 26, 2014, 11:07 p.m., Thomas Lübking wrote: > > you could sighup or sigusr the greeter process and have it > > > > setImmediateLock(true); > > desktopResized(); > > > > in return > > Wolfgang Bauer wrote: > I agree, this would be a bit nicer... > But I tried it and cannot ge

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 6:41 p.m.) Review request for kde-workspace, Pla

Build failed in Jenkins: plasma-desktop_master_qt5 #53

See Changes: [ivan.cukic] Using a fixed ratio since units.displayAspectRatio is removed -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (

Re: Review Request 117601: Improve wallpapers deduplication code a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117601/#review56186 --- Ship it! After a ridiculously lengthy conversation with mck18

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117499/#review56182 --- Ship it! I think this is OK. I see the problem you're trying

Re: Review Request 117627: Let the default taskbar setting for "Show only from current screen" be false

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117627/#review56181 --- Ship it! Ship It! - Eike Hein On April 19, 2014, 12:40 p.m

Re: Polishing sprint in May: dates?

On Monday 31 March 2014, Sebastian Kügler wrote: > > Seems 12th - 16th May works best for most of us. Let's use these dates. > (Arrival Mon, 12th, departure Fri, 16th). Any news on that? things should get moving I think? -- Marco Martin ___ Plasma-dev

Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117499/ --- (Updated April 22, 2014, 10:53 a.m.) Review request for Plasma, Thomas Lü

Minutes Tuesday (aka Monday) Plasma hangout

Present: Aleix, David, Jens, Johnathan, MArco, Martin K, Vishesh Jens * trace everyhting has been done in vdg so far * have to coordinate with Martin K for osd icons * system sounds (tonal) that will be *not* jingles Johnathan * delayed alpha due to frameworks delay * this week will do package of

Re: Re: Proposal to hide raw QML errors in Plasma Next

On Tuesday 22 April 2014 09:59:39 Martin Klapetek wrote: > On Tue, Apr 22, 2014 at 12:53 AM, Aleix Pol wrote: > > You know what's going on by checking what the code is doing. > > > > Can you imagine how life would be if QString class started to output > > information "so that you know what's goin

Re: Review Request 117601: Improve wallpapers deduplication code a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117601/#review56163 --- Can I get a ship it on this? - Martin Klapetek On April 16,

Re: Proposal to hide raw QML errors in Plasma Next

On Tue, Apr 22, 2014 at 12:53 AM, Aleix Pol wrote: > > You know what's going on by checking what the code is doing. > > Can you imagine how life would be if QString class started to output > information "so that you know what's going on"? > > We add output if something weird is happening so that