> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/main.cpp, line 89
> > <https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line89>
> >
> > ooc.: what's wrong about just:
> > signal(SIGUSR1, signalHandler); ?
signal() is deprecated, according to its manpage. "man signal" even says:
The behavior of signal() varies across UNIX versions, and has also var-
ied historically across different versions of Linux. Avoid its use:
use sigaction(2) instead. See Portability below.
> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote:
> > ksmserver/screenlocker/greeter/main.cpp, line 38
> > <https://git.reviewboard.kde.org/r/117091/diff/2/?file=262501#file262501line38>
> >
> > it's nearly academical, but m_instance should be defaulted to NULL and
> > tested here
Yeah, it can't really happen that m_instance isn't set, but anyway. ;)
Before somebody is asking, I'm going to use the signal handler for another
bugfix as well. (bug#224200)
That's why I'm doing the check this way.
- Wolfgang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/#review56190
-----------------------------------------------------------
On April 22, 2014, 9:28 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117091/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 9:28 p.m.)
>
>
> Review request for kde-workspace, Plasma and Aaron J. Seigo.
>
>
> Bugs: 327947 and 329076
> http://bugs.kde.org/show_bug.cgi?id=327947
> http://bugs.kde.org/show_bug.cgi?id=329076
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> If the screen locker is set to not require a password to unlock, it will not
> show the password input field even when the powermanagement settings suspend
> the system and are set to require a password after resume (when it was
> already running at that point).
> This locks people out of their system.
>
> This patch adds a signal handler for SIGUSR1 that switches the running
> greeter to immediateLock mode. The locker sends that signal to make sure the
> greeter shows the password input field when necessary.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.h 8b79188
> ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85
> ksmserver/screenlocker/greeter/main.cpp d898734
> ksmserver/screenlocker/ksldapp.cpp 3dfcc9e
>
> Diff: https://git.reviewboard.kde.org/r/117091/diff/
>
>
> Testing
> -------
>
> Disable "Require password after" in the screen locker settings (the default),
> set it to start after 1 min. (for easier testing).
> Enable "Suspend session after" and set it to 2 minutes. (set the action to
> "Suspend", "Hibernate", or "Lock Screen", doesn't matter)
> Make sure "Lock screen on resume" is enabled in the powermanagements
> "Advanced Options" (it is by default).
>
> After 1 minute the screen locker kicks in, and doesn't require a password.
> After 2 minutes the session gets suspended, hibernated or locked, and
> requires a password to resume.
>
> Without this patch no password dialog is shown, the user cannot resume the
> session by entering the password.
>
> With this patch this works: there is a password input field, the session is
> unlocked when the user enters the password.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
