> On April 17, 2014, 11:30 a.m., Marco Martin wrote: > > If it's for the panel, it shouldn't be done in AppletQuickItem. > > also using AcceptingInputStatus seems a tad arbitrary? > > Aleix Pol Gonzalez wrote: > I don't think it's arbitrary, having an expanded plasmoid requires input > (or interaction), at least to close it. > > Also if it shouldn't be in AppletQuickItem, where should it go? Applet? > > Aleix Pol Gonzalez wrote: > Marco? > > Marco Martin wrote: > hmm, AcceptingInputStatus was intended at the beginning for keyboard > input (to force the panel to accept focus in cases of textboxes inside the > panel) > so would make so that if an applet is always expanded it can only be > acceptinginput, and a panel with a taskbar would always accept focus. > >
So what's your suggestion? Should we move the expanded property to Plasma::Applet, so panel can take it into account? - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117606/#review55951 ----------------------------------------------------------- On April 17, 2014, 11:45 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117606/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 11:45 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch makes sure that the panel containing a plasmoid won't hide when > the plasmoid display is open. > > To do so, it sets a AcceptingInputState while caching the last state, to > restore it when the plasmoid is contracted back. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp fbdc88d > src/plasmaquick/private/appletquickitem_p.h 784899a > > Diff: https://git.reviewboard.kde.org/r/117606/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
