Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Martin Gräßlin
> On April 7, 2014, 6:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's n

Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight

2014-04-08 Thread Jeffrey Enns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/ --- Review request for Plasma. Bugs: 313734 http://bugs.kde.org/show_bug.

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-04-08 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 333191, which changed state. Bug 333191 Summary: create panel action always creates on first screen https://bugs.kde.org/show_bug.cgi?id=333191 What|Removed |Added ---

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Thomas Lübking
> On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's n

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-04-08 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 333193, which changed state. Bug 333193 Summary: panels appear on the primary screen if the secondary is disconnected https://bugs.kde.org/show_bug.cgi?id=333193 What|Removed |Added

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Michael Palimaka
> On April 8, 2014, 2:22 p.m., Thomas Lübking wrote: > > CMakeLists.txt, line 515 > > > > > > not sure whether this or "KDE4_BUILD_TESTS" is the "right" one, but > > this should be sorted out KDE4_BUILD_TESTS i

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Michael Palimaka
> On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's n

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55226 --- CMakeLists.txt

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Thomas Lübking
> On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's n

Re: Visual design for logout/login/lockscreen

2014-04-08 Thread Jens Reuterberg
Well the slidey bit with the background might not be possible - the thing is that it would be awesome to have that as a bit of the animation, same as using the slidey bit in the beginning to load things before password was written in - because then the sensation would be that the desktop started

Re: Review Request 117393: Make building tests optional

2014-04-08 Thread Michael Palimaka
> On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's n

Re: Visual design for logout/login/lockscreen

2014-04-08 Thread Thomas Pfeiffer
On 07.04.2014 17:20, David Edmundson wrote: On Mon, Apr 7, 2014 at 2:12 PM, Kai Uwe Broulik wrote: Hi, What about QtGraphicalEffects ColorOverlay? I've been using it extensively for some time already to colorize white svg icons in my apps as needed. For the breeze theme that will work fine.

Re: Visual design for logout/login/lockscreen

2014-04-08 Thread Thomas Pfeiffer
On 08.04.2014 11:58, Jens Reuterberg wrote: Well the issue is that we have to start being careful what gets crammed in and if too much is crammed in how to hide it away. The point is that too many options visible would be problematic since the main point of a login is to have a place to pick user

Re: Review Request 117433: [applets/notifications] Use ::hide() instead of ::close()

2014-04-08 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117433/#review55217 --- > @MartinK: was there a specific reason to use QWindow::close(

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-04-08 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Marco Martin changed: What|Removed |Added Depends on||333193 -- You are receiving this mail because:

Review Request 117433: [applets/notifications] Use ::hide() instead of ::close()

2014-04-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117433/ --- Review request for Plasma and Martin Klapetek. Repository: plasma-workspa

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-04-08 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Marco Martin changed: What|Removed |Added CC||notm...@gmail.com Depends on|

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

2014-04-08 Thread Marco Martin
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 330757, which changed state. Bug 330757 Summary: Two monitors in clone mode still results in two desktop containments https://bugs.kde.org/show_bug.cgi?id=330757 What|Removed |Added

Re: Visual design for logout/login/lockscreen

2014-04-08 Thread Jens Reuterberg
Well the issue is that we have to start being careful what gets crammed in and if too much is crammed in how to hide it away. The point is that too many options visible would be problematic since the main point of a login is to have a place to pick user and to write in passwords. We could cheat

Re: Visual design for logout/login/lockscreen

2014-04-08 Thread Martin Briza
On Sun, 06 Apr 2014 03:54:03 +0200, Andrew Lake wrote: On Fri, Apr 4, 2014 at 4:37 PM, David Edmundson wrote: Awesome! That login theme in nice, and I like the idea of the visual consistency throughout. I'll have a go at implementing the login stuff on Monday, maybe the lock screen too as it'

Re: Review Request 117359: move phonon kcm and platform plugin to plasma-workspace

2014-04-08 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117359/ --- (Updated April 8, 2014, 7:45 a.m.) Status -- This change has been di