> On April 8, 2014, 2:22 p.m., Thomas Lübking wrote: > > CMakeLists.txt, line 515 > > <https://git.reviewboard.kde.org/r/117393/diff/2/?file=263325#file263325line515> > > > > not sure whether this or "KDE4_BUILD_TESTS" is the "right" one, but > > this should be sorted out
KDE4_BUILD_TESTS is obviously from KDE 4, while BUILD_TESTING is provided by ECM for KF5-land. > On April 8, 2014, 2:22 p.m., Thomas Lübking wrote: > > autotests/CMakeLists.txt, line 1 > > <https://git.reviewboard.kde.org/r/117393/diff/2/?file=263326#file263326line1> > > > > why not find this in the > > if (CORRECT_TEST_BUILD_FLAG) > > branch instead of finding the lib in every subdir? FWIW I prefer this way too. I only used the subdir approach because this was a suggestion from KF5 (although that makes more sense there with just the single root tests/autotests. > On April 8, 2014, 2:22 p.m., Thomas Lübking wrote: > > libkwineffects/CMakeLists.txt, line 119 > > <https://git.reviewboard.kde.org/r/117393/diff/2/?file=263329#file263329line119> > > > > it *might* be reasonable to add all testing dirs conditionally from the > > toplevel CMakeLists.txt - esp. if the lib requirements are checked there as > > well I am more than happy to amend the patch in any way, but I fear that's moot as Martin feels such an option would be detrimental to kwin and other kde-workspace projects. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55226 ----------------------------------------------------------- On April 7, 2014, 2:50 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117393/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 2:50 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Add option to disable building tests, and move the QtTest dependency to be > required only for tests. > > > Diffs > ----- > > CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 > autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 > kcmkwin/kwincompositing/CMakeLists.txt > 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 > kcmkwin/kwincompositing/test/CMakeLists.txt PRE-CREATION > libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 > libkwineffects/autotests/CMakeLists.txt > 8973545cc21b010f1430cf7df20a29da5b14ab43 > tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e > tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 > > Diff: https://git.reviewboard.kde.org/r/117393/diff/ > > > Testing > ------- > > Builds. Tests pass (when enabled). > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
