> On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote: > > I still do not understand the rational behind the change. Could you please > > explain why we would want this build option? > > Michael Palimaka wrote: > It's just nice to have, useful for some people, not useful for others. > It's not a new option, it's been provided by ECM for over a year and of > course KDE4_BUILD_TESTS was floating around before that. > > Martin Gräßlin wrote: > right, but it was a deliberate decision to not honor KDE4_BUILD_TESTS in > kde-workspace/kwin. So I'm just wondering what's the usecase or better put > the advantage for kwin development to have a build option to disable testing. > Personally I don't see any. If your a developer you to run the tests, thus it > should be enabled. If you are a distro you want to run the tests as part of > your package building process. So who would benefit from such a build option? > > Michael Palimaka wrote: > Can we at least move QtTest dependency to tests directories? > > Johannes Huber wrote: > As a source distro the tests run uncoditionally (on end user boxes). So > there is a benefit and please follow the KF5 standardized way of doing > things. Thanks in advance. > > Martin Gräßlin wrote: > > Can we at least move QtTest dependency to tests directories? > > To which one? There are multiple autotests subdirectories. Also the > XCB::ICCCM dependency is not in the tests but in the root CMakeLists.txt and > I like it that way because all XCB dependencies are defined at one place. > > > So there is a benefit > > The benefit has to be weight against the costs. I see an additional cost > on maintenance because we have to remember to add the build dependency > whenever a new subdirectory gets tests or autotests. I see here a high > breakage risk which I do not want to bear (been there with broken build > options - remember OpenGL build option?). If this is really just a build > option to suit the needs of one distribution I think the general rule of no > distro-specific patches has to apply. > > > please follow the KF5 standardized way of doing things > > This is not a KF5 library, thus any rules for KF5 do not apply to KWin. > You might notice that we also don't have a src/ subdirectory.
Well the zero maintenance option is to leave everything where it is making the test-specific stuff conditional on BUILD_TESTING. I am really having trouble understanding why doing this is so offensive, given that it has zero impact on people that don't use it and having such an option is a fairly common thing. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55183 ----------------------------------------------------------- On April 7, 2014, 2:50 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117393/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 2:50 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Add option to disable building tests, and move the QtTest dependency to be > required only for tests. > > > Diffs > ----- > > CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 > autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 > kcmkwin/kwincompositing/CMakeLists.txt > 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 > kcmkwin/kwincompositing/test/CMakeLists.txt PRE-CREATION > libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 > libkwineffects/autotests/CMakeLists.txt > 8973545cc21b010f1430cf7df20a29da5b14ab43 > tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e > tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 > > Diff: https://git.reviewboard.kde.org/r/117393/diff/ > > > Testing > ------- > > Builds. Tests pass (when enabled). > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
