Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review55011 --- This review has been submitted with commit 035eba60fd682a608f

Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 5, 2014, 3:32 a.m.) Status -- This change has been ma

Re: Visual design for logout/login/lockscreen

2014-04-04 Thread David Edmundson
Awesome! That login theme in nice, and I like the idea of the visual consistency throughout. I'll have a go at implementing the login stuff on Monday, maybe the lock screen too as it'll be mostly copy & paste. I have a few things that need adding to the login theme, maybe you can incorporate them

Could someone look at the plasmoid top placement bug?

2014-04-04 Thread Mark Gaiser
Hi, Could someone please look at this bug [1, 2]. The report [2] is on bugzilla for close to two years and is there since KDE 4.10. I am reporting it on the list because the bug is quite annoying if you use plasmoids and is known for quite a while without a solution. Yes, i did try to look in th

Visual design for logout/login/lockscreen

2014-04-04 Thread Andrew Lake
Hello, After reading Aaron's nearly year old blog entry again this week ( http://aseigo.blogspot.de/2013/05/visual-harmony-in-plasma-workspaces-2.html) , especially the following quote: > ...the log out dialog still has things that look like little push buttons and it still has inexplicable > pic

Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review55005 --- Ship it! Ship It! - Shantanu Tushar On April 4, 2014, 1:02

Re: RFC: plasma-shell in pasma-workspace

2014-04-04 Thread Marco Martin
On Thursday 03 April 2014 17:49:33 you wrote: > Hi all, > this was briefly mentioned in the past. > > the idea is to leave only libraries and plugins in plasma-workspace, and > mode plasma-shell in the new plasma-workspace repository instead. > > Is everybody fine with this? > Also, how to do the

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Martin Klapetek
> On March 23, 2014, 12:09 a.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Mark Gaiser
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Review Request 117374: Add a kded module for ksysguard

2014-04-04 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117374/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Martin Klapetek
> On March 23, 2014, 12:09 a.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Mark Gaiser
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Re: Review Request 117356: Remove unused dependencies

2014-04-04 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117356/ --- (Updated April 4, 2014, 1:56 p.m.) Status -- This change has been ma

Re: Review Request 117356: Remove unused dependencies

2014-04-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117356/#review54990 --- This review has been submitted with commit 81c322bf0328fd3df1

Re: Review Request 117359: move phonon kcm and platform plugin to plasma-workspace

2014-04-04 Thread Àlex Fiestas
> On April 3, 2014, 4:19 p.m., Aleix Pol Gonzalez wrote: > > Can you create the patch with --find-copies-harder? It will be much easier > > to review. > > > > Harald Sitter wrote: > I am not sure how that would help as this is a cross-repo move from > kde-runtime (: The kcm should go to p

Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 6:32 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 12:31 p.m.) Status -- This change has been m

Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54983 --- This review has been submitted with commit ff70cda90e786a7998

Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/#review54982 --- Works fine, I can see the values in the table. However, the ac

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Christian Esken
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Review Request 117372: replace kde4-config with kf5-config

2014-04-04 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117372/ --- Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Diego Casella
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as origina

Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54978 --- Ship it! Looks good to me, I have one suggestion below. Make

Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- (Updated April 4, 2014, 11:42 a.m.) Review request for Plasma, Shantanu T

Re: Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54977 --- libs/mediacenter/mediacenter.cpp

Review Request 117368: Resolve first-time-run crash of PMC due to not existing data directory.

2014-04-04 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- (Updated April 4, 2014, 4:21 p.m.) Review request for Plasma, Shantanu Tu

Re: Review Request 112208: KMix qml applet

2014-04-04 Thread Christian Esken
> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. I also haven't heard about further development here. Diego as original submitter or somebody else wou

Re: RFC: plasma-shell in pasma-workspace

2014-04-04 Thread David Edmundson
Makes sense to me. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma-shell in pasma-workspace

2014-04-04 Thread Marco Martin
On Friday 04 April 2014 08:34:14 Martin Gräßlin wrote: > On Thursday 03 April 2014 17:49:33 Marco Martin wrote: > > Hi all, > > this was briefly mentioned in the past. > > > > the idea is to leave only libraries and plugins in plasma-workspace, > > I assume you mean plasma-framework here? eh, ye

Review Request 117365: Add Genre to metadata PMC keeps

2014-04-04 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117365/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

Re: Review Request 117359: move phonon kcm and platform plugin to plasma-workspace

2014-04-04 Thread Harald Sitter
> On April 3, 2014, 4:19 p.m., Aleix Pol Gonzalez wrote: > > Can you create the patch with --find-copies-harder? It will be much easier > > to review. > > I am not sure how that would help as this is a cross-repo move from kde-runtime (: - Harald ---

Re: Review Request 117324: Add logind integration to screenlocker

2014-04-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117324/ --- (Updated April 4, 2014, 9:34 a.m.) Review request for Plasma, Àlex Fiesta