> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote:
> > Is there still an intention on getting this in KDE 4.xx?
> > Just wondering since it seems to be much better then the current kmix popup.
> 
> Christian Esken wrote:
>     I also haven't heard about further development here. Diego as original 
> submitter or somebody else would have to push this. I added this as a topic 
> for the KDE Multimedia Sprint. It takes place in about 4 months (August 
> 2014): https://sprints.kde.org/sprint/212
> 
> Diego Casella wrote:
>     My bad, sorry guys but I'm still in a busy period of my life :/
>     I'll try to fix the remaining issues pointed out in this review request, 
> and then submit the changes here.
>     There is still an ongoing (and BIG imho) issue anyway: we really really 
> really need a Plasma QML callback to capture mouse scroll events. AFAIK there 
> still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix 
> applet, one feature everyone is using is the ability to adjust volume level 
> with just few mouse scrolls over the applet icon.
>     I think we need to fix this problem as well, what do you think?
> 
> Christian Esken wrote:
>     Yes, most definitely we should have mouse scroll events. I guess 
> everybody is using it on the tray icon and in the main window, and so it 
> should also be there for the applet.
>     But if users can choose the plasmoid as an optional, then this is not a 
> showstopper. It is probably better to get it started as is. We could mark it 
> "early-access", so interested people can start playing around with it and 
> using it.

Quote: "There is still an ongoing (and BIG imho) issue anyway: we really really 
really need a Plasma QML callback to capture mouse scroll events...."
Seriously?

I never ever used the scrolling on the tray icon itself. I didn't even know it 
was possible till you said it in this post.
But please don't let such a minor issue block your progress :)

Clicking the icon or using the media keys on most keyboards is probably enough 
possibilities for people change the volume. Scrolling on the icon is imho just 
bonus stuff.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112208/#review53775
-----------------------------------------------------------


On Aug. 27, 2013, 8:40 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112208/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 8:40 a.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and 
> Igor Poboiko.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> KMix qml applet.
> As you can see from the screenshot, the applet is pretty much functional: you 
> can display all the controls available, change its orientation, and decide to 
> whether show all of them or just the Master Control, and refresh its status 
> when new controls are added/removed/updated (such as Amarok current playing 
> track). See screenshots below :)
> Differences from the old kmix tray:
> * no media player controls ( I never investigated how to get them, but 
> honestly opening the audio applet to change/skip/pause audio track makes 
> little sense to me ... if anyone wants this feature back, don't be shy and 
> step in);
> * the button used to select which Mixers are visible has been changed to open 
> Phonon kcm page: since visible mixers are already configurable from KMix app, 
> having a button to show KMix *and* a button to modify Mixers visibilty made 
> little sense here too, so I preferred to give more visibility to Phonon kcm;
> 
> Known issues:
> * there is still no way to get notified of mouse wheel events over the 
> popupIcon, so it is not possible to scroll over to increase/decrease the 
> master control volume;
> * no scroll events over the sliders too;
> * if you want to use the applet you most likely will disable KMix tray icon 
> but, if you do so, KMix will show its GUI at every login and you have to 
> close it manually. This requires KMix to be patched. Furthermore, if you 
> click "KMix Setup" button, KMix window will not restored anymore: this needs 
> to be pathed as well.
> * resize doesn't work properly.
> 
> 
> Diffs
> -----
> 
>   plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml 
> PRE-CREATION 
>   plasma/kmix-applet-qml/contents/ui/VerticalControl.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/112208/diff/
> 
> 
> Testing
> -------
> 
> Tested against master and works fine.
> 
> 
> File Attachments
> ----------------
> 
> Default look
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png
> Menu Actions
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png
> Applet Config Options
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png
> Vertical Control
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png
> ToolButton label and Config page after updates
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png
> Control Icon and Label left aligned
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to