----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117368/#review54977 -----------------------------------------------------------
libs/mediacenter/mediacenter.cpp <https://git.reviewboard.kde.org/r/117368/#comment38360> since your are not using the first_run in another place you should not create a variable with it. You could just do if (!QDir(pcm_path).exists()) { QDir().mkpath(pmc_path); } Also the correct coding style is if (....) { mycontent; } - Antonis Tsiapaliokas On April 4, 2014, 11:21 a.m., Nikolaos Chatzidakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117368/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 11:21 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch resolves the crash of PMC if it's running for the first time and > its data directory does not exist in ~/.kde4/share/apps. > > > Diffs > ----- > > libs/mediacenter/mediacenter.cpp 35240d3 > > Diff: https://git.reviewboard.kde.org/r/117368/diff/ > > > Testing > ------- > > Tested the fix, it creates the directory if it doesn't exist (first-time-run > assumption). > > > Thanks, > > Nikolaos Chatzidakis > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
