Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

> On March 12, 2014, 2:51 p.m., Thomas Lübking wrote: > > Ship It! > > Thomas Lübking wrote: > Do you think the Qt API doc would require a BIG FAT WARNING on this? > > Martin Gräßlin wrote: > wouldn't hurt to have that better. Doesn't need to be a big fat warning, > but at least it sho

Re: (GSoC 2014) Plasma Media Center/Integrate with Plasma Next (with additional ideas)

Hello, Shantanu! Thank you very much for the answer! I got similar advices with others projects and understood my mistakes :) Going to focus better on one or two proposals (guess it will be Plasma Media Center and Kontact Touch People) and start with junior jobs and fixing bugs as soon as possible,

Re: (GSoC 2014) Plasma Media Center/Integrate with Plasma Next (with additional ideas)

Hi, It is of course not too late, you're welcome to join :) Please feel free to submit a proposal and we can review it for you. If you want to get started on some code on PMC, you can start fixing bugs[1] or already implement small features that you wish. Feel free to ask any specific questions t

Re: Review Request 116744: Play All Button in Plasma Media Center

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/#review52812 --- Thanks for the patch, here are some things you can improve in

Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed

> On March 9, 2014, 4:55 p.m., Shantanu Tushar wrote: > > Not having the playlist already loaded has caused us enough issues in the > > past. I suggest we start loading the playlist unconditionally. For this, > > just make a call to getPlaylist() in the init() function in mediacenter.qml > > On

Re: Delaying the Alpha1?

On Wednesday 12 March 2014, Sebastian Kügler wrote: > Hi, > > I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being a > pain in the ass. We're facing a number of problems right now, let me list > them: I can see adefinite problem in delaying: we are holding changes in framewor

Re: Delaying the Alpha1?

> My suggestion is that we give a try to package it tomorrow or on Friday. If > we succeed and it's at least somewhat useable we go for release, otherwise > skip. I like the idea of trying to package it and see where we are, but I would strongly go for giving another 2 weeks. Running a full work

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

> On March 12, 2014, 3:51 p.m., Thomas Lübking wrote: > > Ship It! > > Thomas Lübking wrote: > Do you think the Qt API doc would require a BIG FAT WARNING on this? wouldn't hurt to have that better. Doesn't need to be a big fat warning, but at least it should be mentioned that it doesn't g

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/ --- (Updated March 12, 2014, 3:35 p.m.) Status -- This change has been m

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52785 --- This review has been submitted with commit b3ca2443d6bbe206f5

Re: Review Request 116736: Bug Fixed - The plasma-media center displays the time in AM between 12 noon and 1pm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116736/#review52781 --- There was already a fix at review #114429 and was long pending

Re: Review Request 115870: The plasma-media center displays the time in AM between 12 noon and 1pm.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115870/#review52782 --- There was already a fix at review #114429 and was long pending

Re: Review Request 114429: use of time data engine -> less code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114429/ --- (Updated March 12, 2014, 3:29 p.m.) Status -- This change has been m

Re: Review Request 114429: use of time data engine -> less code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114429/#review52779 --- This review has been submitted with commit a237d0fb4aba0052e0

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

> On March 12, 2014, 2:51 p.m., Thomas Lübking wrote: > > Ship It! Do you think the Qt API doc would require a BIG FAT WARNING on this? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde

Re: Review Request 116712: [kwin] Disconnect lambda connection on destroy of slide effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116712/#review52764 --- Ship it! Ship It! - Thomas Lübking On March 12, 2014, 6:43

Re: Bughunting Season!

On Sunday 09 March 2014 14:00:25 Sebastian Kügler wrote: > Hi all, > > With the feature freeze looming in less than 24 hours, it's time to shift > or focus to quality improvements. We have a whole bunch of new > awesomeness, and perhaps even more new ideas. For now, we'll have to take > a step bac

Re: Delaying the Alpha1?

On Wednesday, March 12, 2014 15:26:08 Martin Klapetek wrote: > Note that the last release of KF5 was alpha2, the next one is beta already. Hah, yes, I meant KF5 Beta. > I'm a bit confused about the dates. I think you mean 28 March, which is when > KF5 beta1 will be tagged. Otherwise I agree, we s

Re: Delaying the Alpha1?

On Wednesday, March 12, 2014 15:31:44 Martin Gräßlin wrote: > On Wednesday 12 March 2014 15:15:12 Sebastian Kügler wrote: > > > > I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being > > a pain in the ass. We're facing a number of problems right now, let me > > list them: > >

Re: Delaying the Alpha1?

On Wednesday 12 March 2014 15:15:12 Sebastian Kügler wrote: > Hi, > > I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being a > pain in the ass. We're facing a number of problems right now, let me list > them: > > - We need some frameworks in newer-than-alpha1-version, notably

Re: Delaying the Alpha1?

Hey, On Wed, Mar 12, 2014 at 3:15 PM, Sebastian Kügler wrote: > Hi, > > I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being a > pain in the ass. We're facing a number of problems right now, let me list > them: > > - We need some frameworks in newer-than-alpha1-version, nota

Re: Delaying the Alpha1?

On Wed, Mar 12, 2014 at 3:15 PM, Sebastian Kügler wrote: > Hi, > > I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being a > pain in the ass. We're facing a number of problems right now, let me list > them: > > - We need some frameworks in newer-than-alpha1-version, notably >

Delaying the Alpha1?

Hi, I'm pondering how much is the Thursday-to-be-tagged alpha worth, vs being a pain in the ass. We're facing a number of problems right now, let me list them: - We need some frameworks in newer-than-alpha1-version, notably kwindowsystem - plasma-framework needs to be repackaged, anyway - every

Re: Review Request 116577: Call malloc_trim() when deleting a dialog

> On March 3, 2014, 8:51 p.m., Martin Gräßlin wrote: > > recommendation: look at kwin/main.cpp kdemain() > > David Edmundson wrote: > Thanks. > > Copy and pasted for lazy: > > #ifdef M_TRIM_THRESHOLD > // Prevent fragmentation of the heap by malloc (glibc). >

Re: [kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

On Wed, Mar 12, 2014 at 2:31 PM, Sebastian Kügler wrote: > On Wednesday, March 12, 2014 14:19:12 Aleix Pol wrote: > > Why don't we just remove it? It's not being used by anything... -.- > > I thought Ivan put it there for a reason. > > I'll add a comment, in any case. > -- > sebas > > http://www.

Re: [kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

On Wednesday, March 12, 2014 14:19:12 Aleix Pol wrote: > Why don't we just remove it? It's not being used by anything... -.- I thought Ivan put it there for a reason. I'll add a comment, in any case. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _

Re: [kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

On Wed, Mar 12, 2014 at 1:46 PM, Sebastian Kügler wrote: > Git commit 4871aaa098d6f71ee554fb341baaa46c6a656633 by Sebastian Kügler. > Committed on 12/03/2014 at 12:43. > Pushed by sebas into branch 'master'. > > Disable Solid.Devices usage > > This breaks with lastest Qt 5.3, and makes the shell

Re: [kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

On Wed, Mar 12, 2014 at 2:13 PM, David Edmundson wrote: > In general I would like work arounds to be documented when commented > out. Ideally with an bug report referenced. > Any person who stumbles across this code is just going to re-enable it. > +1000 to that. Please put more comments in the

Re: [kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

In general I would like work arounds to be documented when commented out. Ideally with an bug report referenced. Any person who stumbles across this code is just going to re-enable it. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.or

[kde-workspace] plasma/desktop/qmlpackages/desktop/contents: Disable Solid.Devices usage

Git commit 4871aaa098d6f71ee554fb341baaa46c6a656633 by Sebastian Kügler. Committed on 12/03/2014 at 12:43. Pushed by sebas into branch 'master'. Disable Solid.Devices usage This breaks with lastest Qt 5.3, and makes the shell crash on startup. Until we've found out the underlying reason, disable

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52725 --- completely unrelated question: does someone have a snippet for

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/ --- (Updated March 12, 2014, 8:27 a.m.) Status -- This change has been m

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52724 --- This review has been submitted with commit 6d403bbc24fcaca39a

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

> On March 11, 2014, 5:24 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt, line 4 > > > > > > Can't we make the target to export the include directories as well? I