> On March 9, 2014, 4:55 p.m., Shantanu Tushar wrote: > > Not having the playlist already loaded has caused us enough issues in the > > past. I suggest we start loading the playlist unconditionally. For this, > > just make a call to getPlaylist() in the init() function in mediacenter.qml > > Once that is done, your patch works (with a small nitpick that if you do it > > multiple times, it adds them to the same playlist. For this you should > > create a new bug so that someone can fix it).
Basically what I want you to do is- getPlaylist().visible = false; //we only want to load it, not to display it in mediacenter.qml's init() method. This will make sure the playlist is instantiated as soon as PMC opens up. As a result, the Play All button in "All Music" mode will start working. You don't need to take care of local browsing as of now, #116744 should be able to fix it. - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review52456 ----------------------------------------------------------- On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116554/ > ----------------------------------------------------------- > > (Updated March 2, 2014, 10:53 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Referring to Bug #331040 The functionality of the media starting to play on > the press of the "Play All" button has been implemented. > It has been noted and implemented that the media doesn't start over when new > songs/videos are added to an existing playlist. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > > Diff: https://git.reviewboard.kde.org/r/116554/diff/ > > > Testing > ------- > > The testing has been done through various test scenarios. > > > Thanks, > > Harshit Agarwal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
