Re: Proposed fix for issue 330115

On Fri, Jan 24, 2014 at 7:09 PM, R.Harish Navnit wrote: > On Fri, Jan 24, 2014 at 6:19 PM, Sinny Kumari wrote: > >> This link is not what you wanted to paste ;) >> > > Oops ! I'm sorry. This is what it was meant to be : http://goo.gl/XLAz2p > > Moreover , now I'm not getting the error log that I

Re: Review Request 115301: Add OSD notifications to plasma-shell

> On Jan. 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/shell/osd.cpp, line 118 > > > > > > This seems a bit risky? > > > > Is it relying on the root item being a Plasma.Dialog? > > > > G

Re: Review Request 115301: Add OSD notifications to plasma-shell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48233 --- src/shell/osd.cpp

Re: Review Request 115301: Add OSD notifications to plasma-shell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48235 --- in general is good, just a preliminary review, pointing out so

Review Request 115301: Add OSD notifications to plasma-shell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Proposed fix for issue 330115

On Fri, Jan 24, 2014 at 6:19 PM, Sinny Kumari wrote: > This link is not what you wanted to paste ;) > Oops ! I'm sorry. This is what it was meant to be : http://goo.gl/XLAz2p Moreover , now I'm not getting the error log that I was getting earlier. It was a little bit different > Also, send dif

Re: [Kde-pim] Baloo based Qml API for (Active) Mail + Plasma

On Thursday 23 January 2014 15.05:02 Michael Bohlender wrote: > Thanks for your input! > > Baloo does not store the data I want, so a mostly baloo based API is not an > option. > This also means that there is no point in modifying the baloo pim search to > retrieve the title because we either need

Re: Proposed fix for issue 330115

> This link is not what you wanted to paste ;) > Also, send diff of code by using "git diff". It will be easier to llok > into issue :) > s/ llok/look typo -- http://www.sinny.in ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Proposed fix for issue 330115

On Fri, Jan 24, 2014 at 5:44 PM, R.Harish Navnit wrote: > Hi , > > I tried running the application after removing the "else continue > statement" , it doesn't seem to work yet . This is the output log : > http://pastebin.kde.org/ . > This link is not what you wanted to paste ;) Also, send diff of

Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48196 --- This review has been submitted with commit c1d715831504b65cd1

Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/ --- (Updated Jan. 24, 2014, 12:17 p.m.) Status -- This change has been m

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/#review48195 --- err, this is actually a qml binding for a class in a framework

Re: Proposed fix for issue 330115

Hi , I tried running the application after removing the "else continue statement" , it doesn't seem to work yet . This is the output log : http://pastebin.kde.org/ . Any help would be appreciated . Thanks a lot . Warm Regards. Thanking You, R.Harish Navnit The Enigma

Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48193 --- Ship it! Looking good. Some niggles, and it's good to go in.

Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/ --- (Updated Jan. 24, 2014, 12:42 p.m.) Review request for kde-workspace and

Re: Proposed fix for issue 330115

On Fri, Jan 24, 2014 at 12:21 AM, Sinny Kumari wrote: > Hi Harish, > > You have done great job!. > Thanks for the compliments :) > > Few things I want to say: > 1. Try to post queries on plasma-devel Mailing List so that you don't have > to wait for reply from one person, any one can reply to yo

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/ --- (Updated Jan. 24, 2014, 11:28 a.m.) Status -- This change has been m

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/#review48191 --- This review has been submitted with commit 3c0007db224212fe9b

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/#review48190 --- Ship it! Ship It! - Sebastian Kügler On Jan. 24, 2014, 11:

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/ --- (Updated Jan. 24, 2014, 4:50 p.m.) Review request for Plasma. Changes -

Re: Review Request 115260: Add default OSD to look&feel package (screenshot included)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48188 --- plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml <

Re: Review Request 115284: Provide KFormat wrapper as QML plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/#review48182 --- Looking quite good already. I'd say we need it documented (in