----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115284/#review48182 -----------------------------------------------------------
Looking quite good already. I'd say we need it documented (in the form of API docs), and then it's good to go in from my side. src/declarativeimports/qtextracomponents/format.h <https://git.reviewboard.kde.org/r/115284/#comment34070> Missing docs here. These can be almost verbatim copies from KFormat, but they're needed here, as we're essentially offering public API. Same hold for other methods. - Sebastian Kügler On Jan. 24, 2014, 7:49 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115284/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 7:49 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > In Plasma1 KLocale wrapper was used to format different things like duration, > it was removed and also KLocale was split up so here is KFormat wrapper to > use this methods. > > I found no better place then qtextracomponents, should be different import? > > > Diffs > ----- > > src/declarativeimports/qtextracomponents/CMakeLists.txt 0ae9e17 > src/declarativeimports/qtextracomponents/format.h PRE-CREATION > src/declarativeimports/qtextracomponents/format.cpp PRE-CREATION > src/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp > d3f8149 > > Diff: https://git.reviewboard.kde.org/r/115284/diff/ > > > Testing > ------- > > Tested formatDuration in battery monitor. > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
