Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44601 --- This review has been submitted with commit 5544e0497e9eb2ccca4

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/ --- (Updated Nov. 27, 2013, 5:22 p.m.) Status -- This change has been mar

Re: Remove X-Plasma-DefaultSize

On Wednesday 27 November 2013, David Edmundson wrote: > Plasma applets currently have a property in their metadata.desktop > files X-Plasma-DefaultSize. > > Currently this appears to be set by most applets but completely unused > in plasma code except for an autotest. > > Given we can determine t

Re: Review Request 112208: KMix qml applet

> On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote: > > I've installed the applet, and had a look in more detail. It's coming along > > really nicely, and already feels a lot better than the QWidget-based kmix. > > :) > > > > Some issues I've found: > > - Resizing the popup dialog doesn't

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44598 --- Ship it! Looks good to me. Please push this patch to master i

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44596 --- Ship it! Ship It! - Shantanu Tushar On Nov. 27, 2013, 4:02

Adding activities button and pager back to default layout

Hello! I think we should add activities button and pager back in panel in Plasma 2.. I want review on this thing (sebas).. Here is screen shot of the layout. http://paste.opensuse.org/84348983 However drag and drop to panel from widget explorer is not working; I have achieved this layout by editi

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/ --- (Updated Nov. 27, 2013, 4:02 p.m.) Review request for Plasma. Repository

Re: Remove X-Plasma-DefaultSize

Thanks, all traces removed now. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

> On Nov. 27, 2013, 3:25 p.m., Sinny Kumari wrote: > > Thank you for patch! > > Please make changes as Sebastian suggested :) > > > > Other than that, there is one issue with this patch. This patch works fine > > in case of All pictures, Flickr and Picasa backend but it maynot work as > > expe

Re: Review Request 114150: Remove KLocale bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/#review44588 --- This review has been submitted with commit 13d1f5568f3b61a9bf3

Re: Review Request 114150: Remove KLocale bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/ --- (Updated Nov. 27, 2013, 3:29 p.m.) Status -- This change has been mar

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44583 --- Thank you for patch! Please make changes as Sebastian suggested

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44584 --- Testing? :) - Sebastian Kügler On Nov. 27, 2013, 3:01 p.m.,

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/ --- (Updated Nov. 27, 2013, 3:01 p.m.) Review request for Plasma. Repository

Re: Review Request 112208: KMix qml applet

> On Sept. 2, 2013, 10:32 p.m., Sebastian Kügler wrote: > > I've installed the applet, and had a look in more detail. It's coming along > > really nicely, and already feels a lot better than the QWidget-based kmix. > > :) > > > > Some issues I've found: > > - Resizing the popup dialog doesn't

Re: Remove X-Plasma-DefaultSize

On Wednesday, November 27, 2013 15:18:52 David Edmundson wrote: > Plasma applets currently have a property in their metadata.desktop > files X-Plasma-DefaultSize. > > Currently this appears to be set by most applets but completely unused > in plasma code except for an autotest. > > Given we can d

Re: Review Request 114149: Fix plasma on multiple monitors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44579 --- Ship it! Tested and confirmed working here. Once Martin's hap

Re: Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44577 --- Please specify in the description of the patch what it does, an

Re: Review Request 114150: Remove KLocale bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/#review44576 --- Ship it! Ship It! - David Edmundson On Nov. 27, 2013, 12:39

Remove X-Plasma-DefaultSize

Plasma applets currently have a property in their metadata.desktop files X-Plasma-DefaultSize. Currently this appears to be set by most applets but completely unused in plasma code except for an autotest. Given we can determine this from the root item's implicitWidth/implicitHeight can I remove t

Review Request 114152: [GCI] FixPicturestrip navigation loop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/ --- Review request for Plasma. Repository: plasma-mediacenter Description --

Re: Review Request 114149: Fix plasma on multiple monitors

> On Nov. 27, 2013, 2:02 p.m., Martin Gräßlin wrote: > > src/shell/desktopview.cpp, lines 144-147 > > > > > > why did you introduce this new slot? It looks to me like you could just > > connet to setGeometry dire

Re: Review Request 114149: Fix plasma on multiple monitors

> On Nov. 27, 2013, 1:02 p.m., Martin Gräßlin wrote: > > src/shell/desktopview.cpp, lines 144-147 > > > > > > why did you introduce this new slot? It looks to me like you could just > > connet to setGeometry dire

Re: Review Request 114149: Fix plasma on multiple monitors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/#review44567 --- src/shell/desktopview.cpp

Review Request 114150: Remove KLocale bindings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114150/ --- Review request for Plasma. Repository: plasma-framework Description

Review Request 114149: Fix plasma on multiple monitors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114149/ --- Review request for Plasma. Repository: plasma-framework Description