> On Nov. 27, 2013, 3:25 p.m., Sinny Kumari wrote: > > Thank you for patch! > > Please make changes as Sebastian suggested :) > > > > Other than that, there is one issue with this patch. This patch works fine > > in case of All pictures, Flickr and Picasa backend but it maynot work as > > expected in case of Browse Pictures. Consider the case when there are 2 > > directories and 4 pictures in current media browser. In Picturestrip, list > > of directories (with width and height 0) will be also there along with > > pictures. Now, when you are currently viewing first picture and then you > > click previous image button, then instead of going to last image it will go > > to previous item which will be a directory. So, in imageviewer you won't > > see blank screen. > > > > To solve this case, As you see that all directories come first and then > > files. So, what you will have to do is, check if current item is a > > directory or file. If it is a directory just ignore them and move to > > next/previous item. > > > > Hint: > > isExpandable role will tell you that whether current item is a directory or > > not. > > You will have to create a property inside listview delegate to access them > > outside listview, property in QML is declared as > > property bool isDirectory: isExpandable > > > > and to access isDirectory property outside listview, use > > imageList.currentItem.isDirectory
Also, if you are wondering whose stupid idea was to just visually hide the directories in the strip rather than filtering them out, it was me and yes I deserve to be kicked :P - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114152/#review44583 ----------------------------------------------------------- On Nov. 27, 2013, 3:01 p.m., Egor Matirov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114152/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 3:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Currently, when you have selected first image from picture strip and clicks > previous image button then nothing happen. Same way, when user reaches to the > last image and clicks next image button, then nothing happens. > This patch fix it. GCI task: > http://www.google-melange.com/gci/task/view/google/gci2013/5783943471169536 > > > Diffs > ----- > > mediaelements/imageviewer/PictureStrip.qml 4825f2e > > Diff: http://git.reviewboard.kde.org/r/114152/diff/ > > > Testing > ------- > > > Thanks, > > Egor Matirov > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
