Re: Review Request: Load and display images in full resolution in imageviewer

2012-10-15 Thread Ruediger Gad
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106907/ --- (Updated Oct. 16, 2012, 6:49 a.m.) Review request for Plasma and Marco Mar

Re: Top-rated documents for the task manager applet

2012-10-15 Thread Ivan Čukić
> sounds for me like waiting for 4.11 and integrate it directly into it is the > proper approach. Honestly, I don't see a reason for it to wait - the questions regarding QML Tasks are mostly: - will it be ready for 4.10? - if yes, is it in a public branch so that I can patch it instead of the

Review Request: Load and display images in full resolution in imageviewer

2012-10-15 Thread Ruediger Gad
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106907/ --- Review request for Plasma and Marco Martin. Description --- In the cu

Re: Top-rated documents for the task manager applet

2012-10-15 Thread Martin Gräßlin
On Tuesday 16 October 2012 00:16:24 Ivan Čukić wrote: > The second reason I haven't yet done any code for this (apart from the QML > model that the libkactivities-models provide) is that I see Eike is porting > the applet to QML, so I wouldn't like to patch one thing, and then need to > patch the n

Top-rated documents for the task manager applet

2012-10-15 Thread Ivan Čukić
Hi all, There is one thing that KActivities provide that I'd like to see in 4.10 apart from SLC, and that is a list of top rated documents for task manager entries (be it launchers - pinned apps - or running ones) One of the ideas I'm having as to where it can be placed is the tooltip that sho

Re: Review Request: Proper fix for DirModel

2012-10-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106901/#review20426 --- Ship it! looks good :) just a couple of minor issues down here

Re: Review Request: Proper fix for DirModel

2012-10-15 Thread Ruediger Gad
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106901/ --- (Updated Oct. 15, 2012, 7:24 p.m.) Review request for Plasma and Marco Mar

Re: Review Request: Fix PlasmaExtras.DisappearAnimation

2012-10-15 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106818/#review20421 --- Ship it! Ship It! - Daker Pinheiro On Oct. 13, 2012, 12:49

Re: SystemTray: QML version #2

2012-10-15 Thread Marco Martin
On Monday 15 October 2012, Dmitry Ashkadov wrote: > Hello! > > I'm working on QML implementation of system tray (branch > plasma/dmitrya/systemtray-qml of kde-workspace). > i gave it a try and seems to work quite well (didn't understand immediately if it was the new one or still the old, and th

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-15 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106789/#review20408 --- Ship it! thanks, working fine (except for that small usability

Re: SystemTray: QML version #2

2012-10-15 Thread Dmitry Ashkadov
15.10.2012 20:20, Aaron J. Seigo ?: On Monday, October 15, 2012 19:20:13 Dmitry Ashkadov wrote: i do notice some small visual issues in the screenshots (thanks for providing those, btw!), mostly to do with spacing and margins in the popup. as you can see in image 05, there is not enough marg

Re: plasma: QGraphicsView-ectomy

2012-10-15 Thread Marco Martin
On Monday 24 September 2012, Marco Martin wrote: > Hi all, > I've committed in the kdelibs branch plasma/mart/qgvremoval a pretty big > diff. it makes Applet inherit only from QObject this causes a nice doino > effect: all api that was coming from QGraphics* isn't there anymore, so i > had to cut p

Re: SystemTray: QML version #2

2012-10-15 Thread Aaron J. Seigo
On Monday, October 15, 2012 19:20:13 Dmitry Ashkadov wrote: > I'm working on QML implementation of system tray (branch > plasma/dmitrya/systemtray-qml of kde-workspace). this is looking insanely sexy :) nice work.. i'll update the branch and re- test later this week (i'm on the road at the moment

Review Request: fix the version of slc

2012-10-15 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106881/ --- Review request for Plasma. Description --- add a version in slc's met

Re: Review Request: Fix battery applet screen power management

2012-10-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review20366 --- Ship it! Ship It! - Lukáš Tinkl On Oct. 10, 2012, 3:13 p.m.

Review Request: Add tooltips to the screensavers KCM

2012-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106876/ --- Review request for Plasma. Description --- After trying to change the

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-15 Thread Aurélien Gâteau
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Add "Screen Resolution" to desktop context menu

2012-10-15 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106862/#review20360 --- this menu is already rather full of fairly random "because peop