----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106901/#review20426 -----------------------------------------------------------
Ship it! looks good :) just a couple of minor issues down here components/dirmodel/dirmodel.cpp <http://git.reviewboard.kde.org/r/106901/#comment16131> you should insert here also a couple of toher roles, since who uses it probably expect to be able to access at least also name and icon in this way components/dirmodel/dirmodel.cpp <http://git.reviewboard.kde.org/r/106901/#comment16130> whitespace - Marco Martin On Oct. 15, 2012, 7:24 p.m., Ruediger Gad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106901/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 7:24 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > Proper fix to DirModel. The previous fix used quite a hack for getting the > URL path of an entity at a given index. > This one implements a generic get method that returns a QVariantMap. > This solution is much more generic as compared to the other hack. Furthermore > it can be easily extended when needed. > > > Diffs > ----- > > applications/filebrowser/imageviewerpart/contents/ui/ViewerPage.qml f06969f > components/dirmodel/dirmodel.h efd4198 > components/dirmodel/dirmodel.cpp 2a85ed0 > > Diff: http://git.reviewboard.kde.org/r/106901/diff/ > > > Testing > ------- > > Builds fine and works. Tested on plasma active on Archos g9. > > > Thanks, > > Ruediger Gad > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
