Re: Review Request: Add "Screen Resolution" to desktop context menu

2012-10-14 Thread Shaun Reich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106862/#review20355 --- plasma/generic/containmentactions/contextmenu/menu.cpp

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Marco Martin
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Kai Uwe Broulik
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Add "Screen Resolution" to desktop context menu

2012-10-14 Thread Kai Uwe Broulik
> On Oct. 15, 2012, 3:06 a.m., Shaun Reich wrote: > > plasma/generic/containmentactions/contextmenu/menu.cpp, line 110 > > > > > > whitespace police! Saw this after I uploaded. Sorry. > On Oct. 15, 2012, 3:06 a.m

Review Request: Add "Screen Resolution" to desktop context menu

2012-10-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106862/ --- Review request for Plasma, KDE Usability and Dan Vrátil. Description -

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Aaron J. Seigo
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Marco Martin
On Sunday 14 October 2012, Kai Uwe Broulik wrote: > > Playing around with ideas a bit more: We could go "all the way" and > > have something like the theme, window deco and wallpaper selectors > > that show a list of the various options in preview. That would > > combine the preview

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Kai Uwe Broulik
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Aaron J. Seigo
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-14 Thread Richard Stockton
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106789/ --- (Updated Oct. 14, 2012, 7:47 p.m.) Review request for Plasma and Greg T.

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-14 Thread Richard Stockton
> On Oct. 13, 2012, 5:43 p.m., Greg T wrote: > > plasma/desktop/applets/kickoff/ui/flipscrollview.cpp, line 436 > > > > > > this is already handled in moveCursor, isn't it? > > Richard Stockton wrote: > I tried

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Kai Uwe Broulik
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Bjoern Balazs
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Humble attempt to improve the ScreenSaver KCM

2012-10-14 Thread Aurélien Gâteau
> On Oct. 8, 2012, 5:31 p.m., Martin Gräßlin wrote: > > just an idea: what about hiding the whole X screen saver stuff behind > > another configure dialog. Looking at the screenshot I find the design puts > > emphasis on the wrong part: what we want to remove takes more than 50 % of > > the av

Re: Review Request: Limit tooltip size for klipper

2012-10-14 Thread Aaron J. Seigo
> On Oct. 13, 2012, 6:47 p.m., Aaron J. Seigo wrote: > > klipper/tray.cpp, line 65 > > > > > > this will not work as expected on multi-screen systems. it needs to > > have the geometry of the screen it will show up

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-14 Thread Richard Stockton
> On Oct. 13, 2012, 5:43 p.m., Greg T wrote: > > plasma/desktop/applets/kickoff/ui/launcher.cpp, line 217 > > > > > > Why did you split that up? All of the other View Variables have the same level of reference, whi

Re: Review Request: Limit tooltip size for klipper

2012-10-14 Thread Xuetian Weng
> On Oct. 13, 2012, 6:47 p.m., Aaron J. Seigo wrote: > > klipper/tray.cpp, line 65 > > > > > > this will not work as expected on multi-screen systems. it needs to > > have the geometry of the screen it will show up

Re: Review Request: Limit tooltip size for klipper

2012-10-14 Thread Marco Martin
> On Oct. 13, 2012, 6:47 p.m., Aaron J. Seigo wrote: > > klipper/tray.cpp, line 65 > > > > > > this will not work as expected on multi-screen systems. it needs to > > have the geometry of the screen it will show up

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-14 Thread Greg T
> On Oct. 13, 2012, 5:43 p.m., Greg T wrote: > > I'm quite satisfied with the keyboard handling after applying your patch. > > > > some notes: > > - when I press key up/down at the top/bottom of a flippscroll view, the > > launcher jumps back to the favourite view. I think it should just stay i