> On Oct. 13, 2012, 6:47 p.m., Aaron J. Seigo wrote: > > klipper/tray.cpp, line 65 > > <http://git.reviewboard.kde.org/r/106829/diff/2/?file=89398#file89398line65> > > > > this will not work as expected on multi-screen systems. it needs to > > have the geometry of the screen it will show up on. > > > > this should probably be put into the notifications UI code instead. > > this way it will be fixed for any user of the notifications and can be set > > for the given screen. > > > > good catch though! > > Xuetian Weng wrote: > Yeah, I know it should be something like that, but the problem here is we > need to strip done too long qstring, but unfortunately I don't have better > idea about this. Or I'd rather put an fixed number here, maybe say about 600 > or so, since the icon size in tooltip is fixed (currently), so a fixed number > won't look bad I think? > > Text will wrap automatically so 600 isn't too large in this case..
the tooltip should indeed have a maximum width, but in characters rather than pixels. very high dpi screens are coming and pixel based sizes make even less sense then ever - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106829/#review20286 ----------------------------------------------------------- On Oct. 13, 2012, 4:31 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106829/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2012, 4:31 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Klipper already limits the text size in the popup menu, however, it doesn't > limit size of tooltip, which can still take up whole screen in some case. > > There used to be another patch have similar idea: > https://git.reviewboard.kde.org/r/103482/ , but I tried to use fontMetrics > based API instead of hardcoded string length, though there is no easy way to > obtain plasma tooltip font size and width is not possible from here (It's not > really impossbile, but it will introduce more depenency, which is wanted). > > > Diffs > ----- > > klipper/tray.cpp 3f4fc83 > > Diff: http://git.reviewboard.kde.org/r/106829/diff/ > > > Testing > ------- > > No problem with an acceptable size. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
