----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106862/#review20355 -----------------------------------------------------------
plasma/generic/containmentactions/contextmenu/menu.cpp <http://git.reviewboard.kde.org/r/106862/#comment16095> whitespace police! plasma/generic/containmentactions/contextmenu/menu.cpp <http://git.reviewboard.kde.org/r/106862/#comment16096> totally nitpicking, but anyone else dislike screen resolution? mostly because it isn't used anywhere else that i could find.. plasma/generic/containmentactions/contextmenu/menu.cpp <http://git.reviewboard.kde.org/r/106862/#comment16097> i believe this needs to be preferences-desktop-display. the -randr is not installed on every system, or at least it isn't on mine? is this icon specific to krandr or something? either that or bring this icon in here and install it without krandr. - Shaun Reich On Oct. 15, 2012, 2:27 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106862/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2012, 2:27 a.m.) > > > Review request for Plasma, KDE Usability and Dan Vrátil. > > > Description > ------- > > This patch adds a context menu entry "Screen Resolution" next to the > Configure $containment entry. > My rationale behind this is that I think many people (especially those from > the Windows world, even more with Win7) expect to be able to manipulate the > Screen Resolution and arrangement settings right from their Desktop. It is > easily adjustable in case kcm_randr gets replaced by the new kscreen-based > one. > Since this was a quick patch I am fine with it not being included, especially > since I do not know what plans there are for the new display configuration in > terms of easy quickaccess using a plasmoid (ie. common settings such as > "Clone", "Projector Only", "Extend Right", etc) > I initially wanted to add the KCM directly to the backgrounddialog thing but > that would have made it too complex, I guess. (I thought there was an easy > function to just add an existing kcm to a paged dialog, but I couldn't > remember). > The wording/appearance of the entry could definitly be better (the ellipsis > should be dropped there, I think) > > > Diffs > ----- > > plasma/generic/containmentactions/contextmenu/menu.h 7ef79d3 > plasma/generic/containmentactions/contextmenu/menu.cpp 33f07e7 > > Diff: http://git.reviewboard.kde.org/r/106862/diff/ > > > Testing > ------- > > Entry shows up (enabled by default), can be enabled and disabled, and > clicking it triggeres the Randr KCM. > > > Screenshots > ----------- > > Context menu entry > http://git.reviewboard.kde.org/r/106862/s/771/ > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
