Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18305 --- This review has been submitted with commit e44b48c6fa1f9875f11

Re: QJSON a mandatory dependency to kde-workspaces?

2012-08-30 Thread Marco Gulino
My fault, sorry... I just forgot about that additional dependency. I think I'll be able to fix it today or tomorrow, by simply disabling chrome support when QJSON is not found. Small problem: there is no builtin CMake script for QJSON, there's one around that works quite fine, however, I've been u

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18304 --- This review has been submitted with commit a97173bbce9085e5df7

Re: Review Request: Weather Forecast QML port

2012-08-30 Thread Luis Gabriel Lima
> On Aug. 30, 2012, 8:21 a.m., Kai Uwe Broulik wrote: > > applets/weather/package/metadata.desktop, line 17 > > > > > > I think it should not be enabled by default but rather > > X-Plasma-NotificationArea=true >

Re: Review Request: Pager QML port

2012-08-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106112/#review18299 --- This review has been submitted with commit 907899076db64c047ce

Re: QJSON a mandatory dependency to kde-workspaces?

2012-08-30 Thread Marco Martin
On Thursday 30 August 2012, Martin Gräßlin wrote: > Hi all, > > since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on > QJSON. In plasma/generic/runners/bookmarks/CMakeLists.txt there is the > following check: > find_package(QJSON REQUIRED) > > unfortunately the macro_log_featur

QJSON a mandatory dependency to kde-workspaces?

2012-08-30 Thread Martin Gräßlin
Hi all, since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on QJSON. In plasma/generic/runners/bookmarks/CMakeLists.txt there is the following check: find_package(QJSON REQUIRED) unfortunately the macro_log_feature is not used, so instead of getting a nice summary of what is

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
> On Aug. 30, 2012, 12:17 p.m., Aurélien Gâteau wrote: > > plasma/declarativeimports/qtextracomponents/fullmodelaccess.h, line 25 > > > > > > I don't like the "FullModelAccess" name. It is a model, so to avoid > > c

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18278 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.h

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18276 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.cp

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18274 --- plasma/declarativeimports/qtextracomponents/fullmodelaccess.h

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- (Updated Aug. 30, 2012, 10:43 a.m.) Review request for Plasma, Aurélien Gâ

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
> On Aug. 30, 2012, 8:34 a.m., Marco Martin wrote: > > while it may be useful being able to access other columns, being able to > > specify the root index duplicates the standard > > http://qt-project.org/doc/qt-4.8/qml-visualdatamodel.html > > > > not sure it is possible combining them tough.

Re: Review Request: Pager QML port

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106112/#review18271 --- Ship it! Ship It! - Marco Martin On Aug. 30, 2012, 2:30 a.m

Re: Review Request: Weather Forecast QML port

2012-08-30 Thread Marco Martin
> On Aug. 30, 2012, 8:21 a.m., Kai Uwe Broulik wrote: > > applets/weather/package/metadata.desktop, line 17 > > > > > > I think it should not be enabled by default but rather > > X-Plasma-NotificationArea=true >

Re: Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/#review18269 --- while it may be useful being able to access other columns, bein

Re: Review Request: Weather Forecast QML port

2012-08-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18267 --- applets/weather/package/metadata.desktop

Review Request: Make it possible to use Tree models from QML

2012-08-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106272/ --- Review request for Plasma, Aurélien Gâteau and Marco Martin. Description -