My fault, sorry... I just forgot about that additional dependency. I think I'll be able to fix it today or tomorrow, by simply disabling chrome support when QJSON is not found. Small problem: there is no builtin CMake script for QJSON, there's one around that works quite fine, however, I've been using it for other project. Should I add this script to kde-workspace? where exactly? Thanks
On Thu, Aug 30, 2012 at 10:06 PM, Marco Martin <[email protected]> wrote: > On Thursday 30 August 2012, Martin Gräßlin wrote: > > Hi all, > > > > since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on > > QJSON. In plasma/generic/runners/bookmarks/CMakeLists.txt there is the > > following check: > > find_package(QJSON REQUIRED) > > > > unfortunately the macro_log_feature is not used, so instead of getting a > > nice summary of what is missing one has to search for something like [1]. > > > > Now fixing this is easy, but before doing so, I wanted to check whether > it > > is really intended to have QJSON as a hard requirement for kde-workspace. > > > > To me this looks like an optional dependency and if not present the > > bookmarks runner is just excluded. > > > > Opinions? > > yeah, seems an oversight. > it should definitely be an optional dependency > > > Cheers, > Marco Martin > _______________________________________________ > Plasma-devel mailing list > [email protected] > https://mail.kde.org/mailman/listinfo/plasma-devel >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
