On Thursday 30 August 2012, Martin Gräßlin wrote: > Hi all, > > since 8f0f84d9575812ee1832d7fabb2c8ee1a9058112 kde-workspace depends on > QJSON. In plasma/generic/runners/bookmarks/CMakeLists.txt there is the > following check: > find_package(QJSON REQUIRED) > > unfortunately the macro_log_feature is not used, so instead of getting a > nice summary of what is missing one has to search for something like [1]. > > Now fixing this is easy, but before doing so, I wanted to check whether it > is really intended to have QJSON as a hard requirement for kde-workspace. > > To me this looks like an optional dependency and if not present the > bookmarks runner is just excluded. > > Opinions?
yeah, seems an oversight. it should definitely be an optional dependency Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
