Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18125 --- Ship it! apart the hardcoded text color that should be correct

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 12:59 p.m., Sebastian Kügler wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > Why not use theme here, if we don't have a fixed background anyway? > > Luis

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18117 --- Ship it! Looking good now :) mainwindow.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 4:06 p.m.) Review request for kwin, Plasma, Sebast

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/ --- (Updated Aug. 27, 2012, 3:52 p.m.) Review request for Plasma and Marco Mar

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

> On Aug. 26, 2012, 7:50 a.m., Greg T wrote: > > besides the points mentioned in review 106125, you have to remember that > > KDE 4.8 is already EOL and there will be no more bugfix release (i.e. > > 4.8.6). > > Richard Stockton wrote: > Yes, but I was asked to put it on the 4.8 tree in ca

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18103 --- applets/weather/package/contents/ui/FiveDaysView.qml

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 12:59 p.m., Sebastian Kügler wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > > > > > Why not use theme here, if we don't have a fixed background anyway? But we a

Re: Review Request: LCD Weather Station QML port

> On Aug. 27, 2012, 9:14 a.m., Martin Klapetek wrote: > > Compared visually (haven't looked at the code), it looks fantastic. Just > > one question - should the new plasmoid also have the "LCD" background? It > > can be seen on the older one, the green-grayish-LCD-like-background, which > > is

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18088 --- applets/weatherstation/package/contents/ui/LCDDisplay.qml

Re: Re: Re: move plasma tools to plasmate

On Monday 27 August 2012 14:25:30 Giorgos Tsiapaliokas wrote: > On 27 August 2012 11:17, Alex Fiestas wrote: > > Plasmate only allows to create plasmoids javascript based afaik and it is > > desgined to do only that (which is cool). Imho it is wy far from being > > an > > sdk. > > A side note

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18087 --- konsole/konsolepreviewer.cpp

Re: Re: move plasma tools to plasmate

On 27 August 2012 11:17, Alex Fiestas wrote: > > Plasmate only allows to create plasmoids javascript based afaik and it is > desgined to do only that (which is cool). Imho it is wy far from being > an > sdk. > A side note here, it is also able to 1. create datanengines, themes, runners, wind

Re: Review Request: Pager QML port

> On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote: > > found a small issue: when there is only one desktop, the pager should show > > nothing and be only few pixels wide (effectively "hidden") > > Marco Martin wrote: > what's the status on this? can it be merged? I'll upload a new diff soo

Re: Review Request: LCD Weather Station QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18079 --- Compared visually (haven't looked at the code), it looks fantas

Re: Review Request: Pager QML port

> On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote: > > found a small issue: when there is only one desktop, the pager should show > > nothing and be only few pixels wide (effectively "hidden") what's the status on this? can it be merged? - Marco -

Re: Re: move plasma tools to plasmate

On Saturday 25 August 2012 18:19:37 Sebastian Kügler wrote: > On Tuesday, August 21, 2012 19:42:16 Alex Fiestas wrote: > > I have changed my mind on this topic with the following conclusion (hope > > it > > is useful for future actions). > > I think it is =) > > > The main reason why I don't lik

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 7:18 a.m.) Review request for kwin, Plasma, Sebast

Re: Review Request: Config cleanup on removeActivity

> On Aug. 27, 2012, 12:42 a.m., Lamarque Vieira Souza wrote: > > Ship It! > > Ivan Čukić wrote: > Which branch is this, since it is not master as specified? (in master, VD switcher is moved into a separate plugin) - Ivan --- This i