Review Request: Plasmate: request to merge terietor/remoteinstaller to master

2012-05-24 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- Review request for Plasma. Description --- Hello, in terietor/remote

Review Request: Plasmate: port Publisher to a ui file and add an install action

2012-05-24 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105031/ --- Review request for Plasma. Description --- Hello, I ported Publisher

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Martin Gräßlin
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Antonis Tsiapaliokas
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Martin Gräßlin
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > > > Antonis Tsiapaliokas wrote: > There is still a big issue here. > > The template of the tabbox that i have put is located in the > kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be > installed becu

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 24, 2012, 1:17 p.m.) Review request for kwin, Plasma and Mart

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Antonis Tsiapaliokas
> On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: > > There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about

Review Request: Fix behavior of "runners" property

2012-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105024/ --- Review request for Plasma. Description --- This commit changes the be

Re: Review Request: Use Config to Provide Activity Icons

2012-05-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105008/#review14117 --- So... what are we going to do with this review request? - Davi

Re: Review Request: Plasmate: fix publisher's combobox and doCMake slot

2012-05-24 Thread Sebastian Kügler
> On May 23, 2012, 6:36 p.m., Giorgos Tsiapaliwkas wrote: > > A side note here. > > Why publisher doesn't use a *.ui file? > > > > I guess that the *.ui are the prefered way as it regards the QWidgets. No? > > Do you want me to port the file into a *.ui file? Yes, that would be good. - Sebast

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973/ --- (Updated May 24, 2012, 9:50 a.m.) Review request for kdelibs and Plasma.

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104959/#review14116 --- This review has been submitted with commit 51924c2f35063e0b0cc