Re: Review Request: "New Desktop" in To Desktop menu

2012-04-29 Thread makis marimpis
> On April 29, 2012, 8:08 p.m., Martin Gräßlin wrote: > > kwin/useractions.cpp, line 505 > > > > > > In KWin code please use the constant value - that's what it's fore :-) > > > > I would also suggest to wr

Re: Review Request: "New Desktop" in To Desktop menu

2012-04-29 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104781/ --- (Updated April 29, 2012, 8:22 p.m.) Review request for kwin and Plasma.

Re: Review Request: Merge the branch KLocaleQMLBindings into master

2012-04-29 Thread Giorgos Tsiapaliwkas
> On April 29, 2012, 12:18 p.m., Marco Martin wrote: > > yes, i think is to merge at this point. > > > > it can be only partial, but the api can map to qml only so much, so i think > > is as far it can go. > > > > to me, the only blocker so far(see below) is that doesn't depend from > > plasm

Re: mpris2 engine and nowplaying QML applet

2012-04-29 Thread David Edmundson
Could you make sure to update this wiki page on QML porting progress: http://community.kde.org/Plasma/PlasmoidScripting#Porting_Plasmoids_to_QML Don't want anyone duplicating your work by mistake. Dave ___ Plasma-devel mailing list Plasma-devel@kde.org h

Re: Review Request: Merge the branch KLocaleQMLBindings into master

2012-04-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104716/#review13067 --- Ship it! yes, i think is to merge at this point. it can be on