----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104716/#review13067 -----------------------------------------------------------
Ship it! yes, i think is to merge at this point. it can be only partial, but the api can map to qml only so much, so i think is as far it can go. to me, the only blocker so far(see below) is that doesn't depend from plasma at all, so should be in the kde namespace plasma/declarativeimports/locale/CMakeLists.txt <http://git.reviewboard.kde.org/r/104716/#comment10163> should be installed under org/kde/locale. the name plasma should not appear at all here plasma/declarativeimports/locale/localebindingsplugin.cpp <http://git.reviewboard.kde.org/r/104716/#comment10162> this should be org.kde.locale. plasma has nothing to do with those - Marco Martin On April 24, 2012, 8:36 p.m., Giorgos Tsiapaliwkas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104716/ > ----------------------------------------------------------- > > (Updated April 24, 2012, 8:36 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > this branch contains QML bindings for KLocale. I believe that is the time to > review it here. > > > Diffs > ----- > > plasma/declarativeimports/locale/CMakeLists.txt PRE-CREATION > plasma/declarativeimports/locale/calendarsystem.h PRE-CREATION > plasma/declarativeimports/locale/calendarsystem.cpp PRE-CREATION > plasma/declarativeimports/locale/locale.h PRE-CREATION > plasma/declarativeimports/locale/locale.cpp PRE-CREATION > plasma/declarativeimports/locale/localebindingsplugin.h PRE-CREATION > plasma/declarativeimports/locale/localebindingsplugin.cpp PRE-CREATION > plasma/declarativeimports/locale/qmldir PRE-CREATION > plasma/declarativeimports/locale/tests/contents/code/klocaleqmltest.qml > PRE-CREATION > plasma/declarativeimports/locale/tests/metadata.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/104716/diff/ > > > Testing > ------- > > there is a plasmoid in kde-runtime/plasma/declarativeimports/locale/tests in > which I have exported every property/q_invokable. > > Some issues that I will like to mention > > a. there is tests/contents/code/klocaleqmltest.qml I believe that it should > be tests/contents/ui/main.qml > b. the test plasmoid is exported as org.kde.klocaleqmltest it should be > org.kde.example.localetest > c. Locale::setActiveCatalog and Locale::setMainCatalog since we didn't want > the bindings to influence the core functionality. > > what do you think? > > > Thanks, > > Giorgos Tsiapaliwkas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
