> On April 29, 2012, 8:08 p.m., Martin Gräßlin wrote: > > kwin/useractions.cpp, line 505 > > <http://git.reviewboard.kde.org/r/104781/diff/2/?file=59479#file59479line505> > > > > In KWin code please use the constant value - that's what it's fore :-) > > > > I would also suggest to write it as: > > if (numberOfDesktops() >= KWIN_MAX_NUMBER_DESKTOPS)
yeah, i skipped it because i'm getting an error that KWIN_MAX_NUMBER_DESKTOPS is undeclared at this scope :/ - makis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104781/#review13111 ----------------------------------------------------------- On April 29, 2012, 8:22 p.m., makis marimpis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104781/ > ----------------------------------------------------------- > > (Updated April 29, 2012, 8:22 p.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > I found > http://community.kde.org/KWin/Ideas#.22New_Desktop.22_in_To_Desktop_menu and > i thought i would be nice to have. > Only a few lines of code. > > > Diffs > ----- > > kwin/useractions.cpp 09e18c3d061f6521749ebfe2665e2db9099dad9f > libs/taskmanager/taskactions.cpp 7917c0d12511937e2ce0092720a82c1e99fcd6bd > libs/taskmanager/taskactions_p.h 52eae0513e62c7dbb3066fc26cd290bada7d1479 > > Diff: http://git.reviewboard.kde.org/r/104781/diff/ > > > Testing > ------- > > Moved client to "New Desktop". Seems to work fine. > > > Thanks, > > makis marimpis > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
