Re: Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Daniel Nicoletti
2012/3/28 Alex Fiestas : > On Wednesday, March 28, 2012 07:22:12 PM Daniel Nicoletti wrote: >> > From a quick look of the code, there's the chance to build the daemon >> > too.. If so, there's no need to do all that work :) About the need of the >> > complete UI, we need it only for one purpose: se

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-28 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated March 29, 2012, 1:58 a.m.) Review request for KDE Runtime and Pla

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-28 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/ --- (Updated March 29, 2012, 2:37 a.m.) Review request for KDE Runtime and Pla

Re: Review Request: Make Kickoff fully functional, using keyboard alone (no mouse).

2012-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104422/#review11968 --- This review has been submitted with commit c5a16ec2b64da98991f

Re: Review Request: Make Kickoff fully functional, using keyboard alone (no mouse).

2012-03-28 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104422/#review11967 --- Ship it! Ship It! - Lamarque Vieira Souza On March 27, 2012

quality/apidox/src

2012-03-28 Thread Sebastian Kügler
SVN commit 1287531 by sebas: Plasma QML apidox script works recursively now This script now takes a base path, walks into it and generates a flat list of html files, just like for the plasma components previously. The script should be run from kde-runtime/plasma/declarativeimports/ like so: q

Re: Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Alex Fiestas
On Wednesday, March 28, 2012 07:22:12 PM Daniel Nicoletti wrote: > > From a quick look of the code, there's the chance to build the daemon > > too.. If so, there's no need to do all that work :) About the need of the > > complete UI, we need it only for one purpose: select which channel will > > be

Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Daniel Nicoletti
> > From a quick look of the code, there's the chance to build the daemon too.. > If so, there's no need to do all that work :) > About the need of the complete UI, we need it only for one purpose: select > which channel will be the Master channel. I can't list all the available > channels insid

Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Diego Casella
> On March 28, 2012, 6:06 p.m., Marco Martin wrote: > > to me the blocker is mostly having to have kmix running... > > since actual kmix would be (sill ;) needed for the actual complete ui... > > what about this? > > > > a modification in the systray applet, that queries sycoca for offers of >

Re: [plasma-mobile] /: Rewrite and use FindKActivities.cmake.

2012-03-28 Thread Alexander Neundorf
On Monday 26 March 2012, Michael Jansen wrote: > Git commit 83994459634aba64f57b29ac9e666b37ae28dfad by Michael Jansen. > Committed on 26/03/2012 at 22:38. > Pushed by mjansen into branch 'master'. > > Rewrite and use FindKActivities.cmake. > > I wonder if the NO_MODULE parameter is used correctl

Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6928/ --- (Updated March 28, 2012, 6:49 p.m.) Review request for Plasma, Aaron Seigo,

Re: Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6928/#review10739 --- to me the blocker is mostly having to have kmix running... since

Review Request: KMix Declarative Applet - First attempt

2012-03-28 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6928/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Description ---

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-28 Thread Ivan Cukic
On Wednesday, 28. March 2012. 9.52.20 Djuro Drljaca wrote: > Why don't you just let the user decide what he wants to do ... let him > choose between "move to private activity" and "copy to private > activity". It is all or nothing. If you allow the user to choose anything related to security, it

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-28 Thread Djuro Drljaca
Why don't you just let the user decide what he wants to do ... let him choose between "move to private activity" and "copy to private activity". Also for "move to private activity" you should first check the file permissions and if all the files are not movable then notify the user about it. _

Re: Review Request: Copy files instead of moving if parent dir is not writable

2012-03-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/#review11942 --- I don't mind this approach - some things need to be related to