----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104422/#review11968 -----------------------------------------------------------
This review has been submitted with commit c5a16ec2b64da98991f67dcd991c33abc3888c5c by Rick Stockton to branch KDE/4.8. - Commit Hook On March 27, 2012, 5:26 a.m., Richard Stockton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104422/ > ----------------------------------------------------------- > > (Updated March 27, 2012, 5:26 a.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Description > ------- > > Kickoff needs a way to enter the "All Applications" Tab, using only the > keyboard. > > With this patch, pressing 'Qt::Key_Up' or 'Qt::Key_Down' will leave the > 'Launcher' and enter the "Applications" View content area, when the > "Applications" icon is highlighted in the tab bar. From inside the "All > Applications" Widget, the User may press Qt::Key_Tab to return to the > Launcher (for switching to another tab, or for performing a search.) > Qt::Key_Tab must generally be pressed TWICE. > > This makes entry into the "Applications" tab, and exit back to the Launcher, > the same as the other tabs (i.e., "Favorites", "Recently Used", "Computer", > and "Leave"). This is a patch only for 4.8, because widget-based Kickoff will > be replaced with a QML launcher in KDE 4.9. > > > This addresses bugs 276932 and 296696. > http://bugs.kde.org/show_bug.cgi?id=276932 > http://bugs.kde.org/show_bug.cgi?id=296696 > > > Diffs > ----- > > plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 > > Diff: http://git.reviewboard.kde.org/r/104422/diff/ > > > Testing > ------- > > compiled, tested, and using in production. > > Note for testers: There is one bit of weirdness, not new, and it's the same > with all of the Other Tabs: From inside the tab's content area, you must make > TWO KeyPress events of Qt::Key_Tab in order to highlight the search bar > TextEdit Widget properly. I don't know exactly "where" focus goes after the > first Tab keyPressEvent, when neither the content area nor the search > TextEdit are highlighted. (And I'm not going to waste time figuring it out, > because this all gets replaced with 4.9.) > > > Thanks, > > Richard Stockton > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
