----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/#review11942 -----------------------------------------------------------
I don't mind this approach - some things need to be related to the private activity that can't be encapsulated in it. The things that should be added here are (something I forgot) is first to check whether url is a local file or not. If not, it should act like it is unmovable. (web pages...) - Ivan Čukić On March 27, 2012, 2:22 p.m., Lamarque Vieira Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104417/ > ----------------------------------------------------------- > > (Updated March 27, 2012, 2:22 p.m.) > > > Review request for KDE Runtime and Plasma. > > > Description > ------- > > When adding an application resource to a private activity kactivitymanager > tries to move the resource's .desktop file to the activity's private folder. > The new .desktop file is created successfully but the source file is not > deleted if the user does not have write permission on the file's directory. > This patch detects such situation and uses copy instead of move to prevent > "permission denied" messages for every resource being added. > > > This addresses bug 296808. > http://bugs.kde.org/show_bug.cgi?id=296808 > > > Diffs > ----- > > service/jobs/nepomuk/Move.h 8a8afd1 > service/jobs/nepomuk/Move.cpp 08a3cc2 > > Diff: http://git.reviewboard.kde.org/r/104417/diff/ > > > Testing > ------- > > Works on Meego devel image. The file is copied and no error message is shown. > > > Thanks, > > Lamarque Vieira Souza > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
