Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Burkhard Lück
> On May 24, 2011, 8:45 p.m., Aurélien Gâteau wrote: > > Looks good now. Note that it would be nice to revisit this change when KDE > > 4.7 is out and string freeze is no longer in effect: either the "" > > should be put back in the i18n() call or the "" should be taken out of > > the i18n() c

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/#review3493 --- Ship it! Looks good now. Note that it would be nice to revisit

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/ --- (Updated May 24, 2011, 2:55 p.m.) Review request for Plasma. Changes ---

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/#review3476 --- The patch makes sense, but it breaks string freeze. You can eith

Re: Review Request: The tooltip's tag are mismatch on krandrtray

2011-05-24 Thread Max Lin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/ --- (Updated May 24, 2011, 9:26 a.m.) Review request for Plasma. Summary ---