----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/#review3493 -----------------------------------------------------------
Ship it! Looks good now. Note that it would be nice to revisit this change when KDE 4.7 is out and string freeze is no longer in effect: either the "<tr>" should be put back in the i18n() call or the "</tr>" should be taken out of the i18n() call. The second option feels better to me, as translators shouldn't have to care about the "tr" (but right-to-left translators need access to the "td") - Aurélien On May 24, 2011, 2:55 p.m., Max Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101430/ > ----------------------------------------------------------- > > (Updated May 24, 2011, 2:55 p.m.) > > > Review request for Plasma. > > > Summary > ------- > > After launch krandrtray, move cursor up on krandrtray, it will shows tooltip, > however, looks the tag are not match so caused context are not aligned, and > text color are not consistent, we also can catch the "tag mismatch" debug > message. I added "<tr>" tag to match with "</tr>" tag, after with this patch, > the "tag mismatch" message disappear. > > > Diffs > ----- > > kcontrol/randr/krandrtray.cpp aab7295 > > Diff: http://git.reviewboard.kde.org/r/101430/diff > > > Testing > ------- > > Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screenshot > before/after with this patch. > > > Screenshots > ----------- > > tag mismatch > http://git.reviewboard.kde.org/r/101430/s/172/ > tag match > http://git.reviewboard.kde.org/r/101430/s/173/ > > > Thanks, > > Max > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
