----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101430/#review3476 -----------------------------------------------------------
The patch makes sense, but it breaks string freeze. You can either: 1. add "<tr>" outside of the call to i18n() (something like "<tr>" + i18n(... ) or, 2. request a string exception on kde-i18n-doc@ to introduce this change. - Aurélien On May 24, 2011, 9:26 a.m., Max Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101430/ > ----------------------------------------------------------- > > (Updated May 24, 2011, 9:26 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > After launch krandrtray, move cursor up on krandrtray, it will shows tooltip, > however, looks the tag are not match so caused context are not aligned, and > text color are not consistent, we also can catch the "tag mismatch" debug > message. I added "<tr>" tag to match with "</tr>" tag, after with this patch, > the "tag mismatch" message disappear. > > > Diffs > ----- > > kcontrol/randr/krandrtray.cpp aab7295 > > Diff: http://git.reviewboard.kde.org/r/101430/diff > > > Testing > ------- > > Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screenshot > before/after with this patch. > > > Screenshots > ----------- > > tag mismatch > http://git.reviewboard.kde.org/r/101430/s/172/ > tag match > http://git.reviewboard.kde.org/r/101430/s/173/ > > > Thanks, > > Max > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
