Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Aaron Seigo
> On March 5, 2011, 8:25 a.m., Aaron Seigo wrote: > > "When I request an source for Mixer, it also adds soucres for controls. And > > then when I request source for already available Control, it doesn't react > > anyhow. But when I set "Update every % ms", and click "Reqeust", it works > > fin

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Igor Poboiko
> On March 5, 2011, 8:25 a.m., Aaron Seigo wrote: > > "When I request an source for Mixer, it also adds soucres for controls. And > > then when I request source for already available Control, it doesn't react > > anyhow. But when I set "Update every % ms", and click "Reqeust", it works > > fin

Re: Review Request: Option to set no title for the folderview applet

2011-03-05 Thread Farhad Hedayati Fard
> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote: > > nice idea :) > > > > there is a string translation (localization) issue on lines 615-617 and a > > handful of whitespace issues. once those are addressed, please commit. > > J Janz wrote: > * On strings, some thoughts: > >

Re: Review Request: Properly resize panel when screen resolution is lowered

2011-03-05 Thread Marco Martin
On Saturday 05 March 2011, Yuen Hoe Lim wrote: > > On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote: > > > nice fix; i have a feeling this code could be simplified somewhat, but > > > let's cover all the corner cases first. > > > > > > the issue you note about setting the size in a larger resolut

Re: Review Request: Properly resize panel when screen resolution is lowered

2011-03-05 Thread Yuen Hoe Lim
> On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote: > > nice fix; i have a feeling this code could be simplified somewhat, but > > let's cover all the corner cases first. > > > > the issue you note about setting the size in a larger resolution and then > > switching back to a smaller one is a

Re: Review Request: Properly resize panel when screen resolution is lowered

2011-03-05 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100799/#review1773 --- Ship it! nice fix; i have a feeling this code could be simplifi

Re: Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/#review9951 --- "When I request an source for Mixer, it also adds soucres for cont

Review Request: Properly resize panel when screen resolution is lowered

2011-03-05 Thread Yuen Hoe Lim
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100799/ --- Review request for Plasma. Summary --- This should fix one of the rep

Review Request: Rework KMix DBus API and add KMix plasma dataengine

2011-03-05 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6587/ --- Review request for Plasma and Diego Casella. Summary --- This patch rew