> On March 5, 2011, 9:22 a.m., Aaron J. Seigo wrote: > > nice fix; i have a feeling this code could be simplified somewhat, but > > let's cover all the corner cases first. > > > > the issue you note about setting the size in a larger resolution and then > > switching back to a smaller one is an interesting one indeed. the goal was > > (and i stress _was_, as we can alter this :) to allow per-resolution panel > > settings. but as you note, that may not indeed be what is wanted/expected > > all the time. > > > > for now, in terms of fixing this stuff up for 4.6.2, i don't think we need > > to address it. but for 4.7 it might be nice to lay down some arbitrary > > "rules" for panel sizing between resolution changes that keeps some > > flexibility and obeys "least surprise" as much as possible and (re-?)write > > this code to match those rules.
Thanks. Pushed to master. Umm, is there something else I need to do in order for this to appear in 4.6.2? - Yuen Hoe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100799/#review1773 ----------------------------------------------------------- On March 5, 2011, 9:06 a.m., Yuen Hoe Lim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100799/ > ----------------------------------------------------------- > > (Updated March 5, 2011, 9:06 a.m.) > > > Review request for Plasma. > > > Summary > ------- > > This should fix one of the reported problems in bug 209962. It prevents parts > of the panel from going off-screen when the screen resolution is reduced by > reducing the offset (if the panel can fit and is just not positioned to) or > by reducing the panel size if the panel is larger than the screen. I'm just > basically following what the "pinching strategy" comment written there in the > source file says, since it seems to have not been implemented. > > I also noted while working on this that the panel saves its sizes to config > when the screen size changes, and later _always_ restores this setting > whenever the screen size is reverted. This creates the following somewhat > unintuitive possibility: > > - at resolution 1 I maximize the panel > - I change the screen to resolution 2 that is not too much larger or smaller > than resolution 1 > - at resolution 2 I make the panel very small, say 20% of the screen width > - now I switch back to resolution 1 > - the panel becomes maximized again (because the maximized size is saved and > associated with resolution 1) > > Is this intended behavior? Or should that be fixed in some way too? > > (first git patch btw, hope I didn't do anything wrong..) > > > This addresses bug 209962. > http://bugs.kde.org/show_bug.cgi?id=209962 > > > Diffs > ----- > > plasma/desktop/shell/panelview.cpp ee5abca > > Diff: http://git.reviewboard.kde.org/r/100799/diff > > > Testing > ------- > > Basic testing on trunk, seems to work. Notably despite what is written in the > bug page, this issue affects non-multi-screen setups as well. It's a > change-in-resolution issue. > > > Thanks, > > Yuen Hoe > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
