-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100799/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This should fix one of the reported problems in bug 209962. It prevents parts
of the panel from going off-screen when the screen resolution is reduced by
reducing the offset (if the panel can fit and is just not positioned to) or by
reducing the panel size if the panel is larger than the screen. I'm just
basically following what the "pinching strategy" comment written there in the
source file says, since it seems to have not been implemented.
I also noted while working on this that the panel saves its sizes to config
when the screen size changes, and later _always_ restores this setting whenever
the screen size is reverted. This creates the following somewhat unintuitive
possibility:
- at resolution 1 I maximize the panel
- I change the screen to resolution 2 that is not too much larger or smaller
than resolution 1
- at resolution 2 I make the panel very small, say 20% of the screen width
- now I switch back to resolution 1
- the panel becomes maximized again (because the maximized size is saved and
associated with resolution 1)
Is this intended behavior? Or should that be fixed in some way too?
(first git patch btw, hope I didn't do anything wrong..)
This addresses bug 209962.
http://bugs.kde.org/show_bug.cgi?id=209962
Diffs
-----
plasma/desktop/shell/panelview.cpp ee5abca
Diff: http://git.reviewboard.kde.org/r/100799/diff
Testing
-------
Basic testing on trunk, seems to work. Notably despite what is written in the
bug page, this issue affects non-multi-screen setups as well. It's a
change-in-resolution issue.
Thanks,
Yuen Hoe
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
