Error while building

2010-10-01 Thread sujith h
Hi, I had found an error while building the kdebase. The error actually pointed for the requirement saying it needs 0.6.0 version of dbusmenu-qt. I had updated the dbusmenu-qt by pulling it from the gitorious. And its already updated. Again am facing the same issue with the kdebase build. A helpin

Re: Review Request: Optional passive calendar popup for the Digital Clock

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5513/#review7934 --- as discussed earlier today on irc, and for all the reasons discuss

Review Request: Optional passive calendar popup for the Digital Clock

2010-10-01 Thread Mark
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5513/ --- Review request for Plasma. Summary --- I know some people don't like th

Re: Review Request: use sqlite for storage

2010-10-01 Thread Marco Martin
> On 2010-10-01 17:13:46, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/private/storage.cpp, line 41 > > > > > > instead of an incrementing connectionId, you could also use the value > > of the this pointer? one le

Re: Review Request: Use Plasma::ScrollWidget in the widget explorer

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4676/#review7930 --- Ship it! update to current trunk if needed, and let's get this in

Re: Review Request: Do not use tree view for categories in the vertical widgets explorer

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5446/#review7929 --- Ship it! much nicer. - Aaron On 2010-09-27 10:57:33, Anselmo L

Re: Review Request: bug fixes for the system-monitor applet

2010-10-01 Thread Aaron Seigo
> On 2010-09-25 08:31:36, Petri Damstén wrote: > > Looks good to me. has it been committed? if not, can you please do so, and mark this as submitted. thanks. - Aaron --- This is an automatically generated e-mail. To reply, visit: http:

Re: Review Request: Fix PaintUtils::shadowText() placement

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5504/#review7927 --- Ship it! - Aaron On 2010-10-01 02:00:06, Christoph Feck wrote:

Re: Review Request: use sqlite for storage

2010-10-01 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5506/#review7926 --- the implementation looks good; my one question is regards keeping

Re: Adding "Set Wallpaper" Option In Frame Applet

2010-10-01 Thread Aaron J. Seigo
On Friday, October 1, 2010, Sinny Kumari wrote: > So no one has a suggestion, or am I doing something terribly wrong? sorry, just a very busy week for me and things are falling through the cracks. thanks for bringing this thread back to life :) > On 9/30/10, Sinny Kumari wrote: > > and class Co

Review Request: use sqlite for storage

2010-10-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5506/ --- Review request for Plasma. Summary --- looking at how slow kconfig as,

Re: Review Request: allow SVGs to use systemcolors

2010-10-01 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5495/#review7925 --- Ship it! i think it's pretty good now - Marco On 2010-10-01 14

Re: Review Request: allow SVGs to use systemcolors

2010-10-01 Thread Marco Martin
> On 2010-09-30 13:10:03, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 107 > > > > > > a check elements with the same id aren't existing should be done > > Manuel Mommertz wrote: > You are righ

Re: Review Request: allow SVGs to use systemcolors

2010-10-01 Thread Marco Martin
> On 2010-09-30 13:10:03, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 441 > > > > > > so the coloring of the pixmap is still kept as retrocompatibility? > > Manuel Mommertz wrote: > I don't wa

Re: Review Request: allow SVGs to use systemcolors

2010-10-01 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5495/ --- (Updated 2010-10-01 14:25:03.138571) Review request for Plasma. Summary --

Re: Adding "Set Wallpaper" Option In Frame Applet

2010-10-01 Thread Sinny Kumari
So no one has a suggestion, or am I doing something terribly wrong? On 9/30/10, Sinny Kumari wrote: > Hi, > > I want to add "Set Wallpaper" option in Frame Applet. while doing > this, I found one option in directory > trunk/kde/src/KDE/kdelibs/plasma/ in the containment.cpp file which > emits

Re: Review Request: allow SVGs to use systemcolors

2010-10-01 Thread Manuel Mommertz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5495/ --- (Updated 2010-10-01 08:19:06.216337) Review request for Plasma. Changes --