----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5506/ -----------------------------------------------------------
Review request for Plasma. Summary ------- looking at how slow kconfig as, this makes storage use sqlite (and makes some methods private, before it's too late) it can still use some improvements but it's basically working. two main concerns are: - is acceptable/safe to link to QtSql and assume the sqlite driver is present? - i would still see this as a fallback for when an akonadi version is not present (being in another process should slowdown the gui a bit less, but i could not want it in some mobile profiles) the akonadi version is in the usual status "almost working with developer disappeared" :p Diffs ----- /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1179394 /trunk/KDE/kdelibs/plasma/datacontainer.h 1179394 /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1179394 /trunk/KDE/kdelibs/plasma/dataengine.cpp 1179394 /trunk/KDE/kdelibs/plasma/private/datacontainer_p.h 1179394 /trunk/KDE/kdelibs/plasma/private/storage.cpp 1179394 /trunk/KDE/kdelibs/plasma/private/storage_p.h 1179394 Diff: http://svn.reviewboard.kde.org/r/5506/diff Testing ------- Thanks, Marco
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel