> On 2010-09-30 13:10:03, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 107 > > <http://svn.reviewboard.kde.org/r/5495/diff/1/?file=38739#file38739line107> > > > > a check elements with the same id aren't existing should be done > > Manuel Mommertz wrote: > You are right. But this would add more clutter. Maybe it is better to > just leave the id as is. So no hint-uses-color-scheme but only > current-color-scheme.
so should be specified in the theme documentation that it is reserved - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5495/#review7905 ----------------------------------------------------------- On 2010-10-01 14:25:03, Manuel Mommertz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5495/ > ----------------------------------------------------------- > > (Updated 2010-10-01 14:25:03) > > > Review request for Plasma. > > > Summary > ------- > > With this patch applied SVGs can put a style-element with id > 'current-system-colors' in it, which gets replaced by a style with the > current systemcolors. This allows SVGs to use colors like background color > and text color from the system palette. Giving themes much more possibilitys > then just coloring the resulting pixmap. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/theme.h 1180314 > /trunk/KDE/kdelibs/plasma/theme.cpp 1180314 > /trunk/KDE/kdelibs/plasma/svg.cpp 1180314 > > Diff: http://svn.reviewboard.kde.org/r/5495/diff > > > Testing > ------- > > Changing theme, changing colorscheme > > > Screenshots > ----------- > > Default Colorscheme > http://svn.reviewboard.kde.org/r/5495/s/520/ > green-gray Colorscheme > http://svn.reviewboard.kde.org/r/5495/s/522/ > > > Thanks, > > Manuel > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
