Re: Plasma Desktop Scripting Question

2010-07-31 Thread Jeremiah Summers
On Sat, Jul 31, 2010 at 5:51 PM, Aaron J. Seigo wrote: > On July 31, 2010, Jeremiah Summers wrote: >> Maybe I missed something, I have been reading through techbase and a >> few fourms and mailinglist and I haven't found any mention of being >> able to change the widgetStyle in plasma through ecma

KDE/kdebase/workspace/plasma/netbook/shell

2010-07-31 Thread Raphael Kubo da Costa
SVN commit 1157732 by rkcosta: Fix build with gcc < 4.3.0. The issue was brought up on the kde-packager/release-team mailing lists[1], and it turns out to be a bug in gcc itself related to an iffy part of the c++ spec[2][3]. Thanks a lot to SadEagle (Maksim Orlovich) for helping chase the cause

Re: Review Request: battery: change brightness on mouse wheel

2010-07-31 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4810/#review6758 --- you don't need to propagate wheel events (or most other events, for th

Review Request: battery: change brightness on mouse wheel

2010-07-31 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4810/ --- Review request for Plasma. Summary --- This implements feature requested in

Re: Plasma Desktop Scripting Question

2010-07-31 Thread Aaron J. Seigo
On July 31, 2010, Jeremiah Summers wrote: > Maybe I missed something, I have been reading through techbase and a > few fourms and mailinglist and I haven't found any mention of being > able to change the widgetStyle in plasma through ecma/Javascript. If > this is at all possible (with 4.5?) would a

Re: Review Request: battery: Support for any amount of brightness devices

2010-07-31 Thread Rafa? Mi?ecki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4796/#review6757 --- Commited in following commits: 1157703 1157711 1157714 1157716 Commit

Re: Review Request: battery: Support for any amount of brightness devices

2010-07-31 Thread Rafa? Mi?ecki
> On 2010-07-31 14:18:23, Sebastian Kügler wrote: > > After you've done those changes, feel free to commit to trunk, please also > > backport to 4.5. Thank you for review! - Rafa? --- This is an automatically generated e-mail. To reply

Plasma Desktop Scripting Question

2010-07-31 Thread Jeremiah Summers
Maybe I missed something, I have been reading through techbase and a few fourms and mailinglist and I haven't found any mention of being able to change the widgetStyle in plasma through ecma/Javascript. If this is at all possible (with 4.5?) would anyone know of a example they could point me too or

Re: KDE

2010-07-31 Thread Marco Martin
On Saturday 31 July 2010, Aaron J. Seigo wrote: > On July 31, 2010, Marco Martin wrote: > > SVN commit 1157537 by mart: > > > > The Desktop ToolBox and the Panel ToolBox becomes plugins, shipped with > > Plasma-Desktop (so shells have to implement their own plugins or pick > > one already installe

Re: KDE

2010-07-31 Thread Aaron J. Seigo
On July 31, 2010, Marco Martin wrote: > SVN commit 1157537 by mart: > > The Desktop ToolBox and the Panel ToolBox becomes plugins, shipped with > Plasma-Desktop (so shells have to implement their own plugins or pick > one already installed) we really need to document what it takes to implement a

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Aaron J. Seigo
On July 31, 2010, Giulio Camuffo wrote: > 1) We could modify the handle constructor to let it pass a QGraphicsWidget > instead of an Applet and then check things like > hasConfigurationInterface() using the property() method. Still it would hm, too many assumptions and too many code paths. steppi

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Giulio Camuffo
> i think the generic handle plugin and > should still be limited to Applets. > the ability to manage normal > QGraphicsWidgets could be added to your particular iplementation (and you > would pass 0 as parent in this case) ah ok, but that way i'd have anyway to reimplement all the logic behind th

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Marco Martin
On Saturday 31 July 2010, Giulio Camuffo wrote: > > why > > souldn't be an Applet? the problem is your containment? > > If we want to be able to use the handle with different widgets than the > applets we have to pass a QGraphicsWidget to its ctor, right? Or maybe > you're saying we could keep the

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Giulio Camuffo
> why > souldn't be an Applet? the problem is your containment? If we want to be able to use the handle with different widgets than the applets we have to pass a QGraphicsWidget to its ctor, right? Or maybe you're saying we could keep the current ctor and add another one? ___

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Marco Martin
On Saturday 31 July 2010, Giulio Camuffo wrote: > In data giovedì 29 luglio 2010 21:11:05, Marco Martin ha scritto: > > On Thu, Jul 29, 2010 at 6:46 PM, Giulio Camuffo wrote: > > > In data giovedì 29 luglio 2010 18:09:10, Marco Martin ha scritto: > > >> if this works out, i would like to try it fo

Re: Review Request: battery: Support for any amount of brightness devices

2010-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4796/#review6755 --- Ship it! After you've done those changes, feel free to commit to trun

Re: Review Request: battery: Support for any amount of brightness devices

2010-07-31 Thread Sebastian Kügler
> On 2010-07-30 14:54:15, Rafa? Mi?ecki wrote: > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp, > > line 528 > > > > > > Naming devices would be great, however names seems to be like: > > "/o

Re: toolbox (and applethandle?) architecture rewamp

2010-07-31 Thread Giulio Camuffo
In data giovedì 29 luglio 2010 21:11:05, Marco Martin ha scritto: > On Thu, Jul 29, 2010 at 6:46 PM, Giulio Camuffo > wrote: > > In data giovedì 29 luglio 2010 18:09:10, Marco Martin ha scritto: > >> if this works out, i would like to try it for applet handles as well > >> in the future (in this

KDE

2010-07-31 Thread Marco Martin
SVN commit 1157537 by mart: The Desktop ToolBox and the Panel ToolBox becomes plugins, shipped with Plasma-Desktop (so shells have to implement their own plugins or pick one already installed) Unfortunately, 3 virtuals were needed in AbstractToolBox void restore(const KConfigGroup &group); void s