Re: Review Request: Fix a bogus message indicator item in hidden system tray popup

2010-07-08 Thread Octavian Voicu
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4541/ --- (Updated 2010-07-08 21:06:50.086050) Review request for Plasma. Summary (updat

Re: Review Request: Fix a bogus message indicator item in hidden system tray popup

2010-07-08 Thread Octavian Voicu
> On 2010-07-08 18:23:27, Beat Wolf wrote: > > i actually didn't look at the patch itself, just informed where to submitt > > the patch :) Actually that's what I was trying to say :) I edited the description to include the information I sent with the patch on the bug tracker. - Octavian -

Re: initial plasmoid size?

2010-07-08 Thread Thomas Fjellstrom
On July 8, 2010, Thomas Fjellstrom wrote: > On July 7, 2010, Thomas Fjellstrom wrote: > > On July 7, 2010, Marco Martin wrote: > > > On Wed, Jul 7, 2010 at 2:38 PM, Thomas Fjellstrom > > > > > > > wrote: > > > > On July 7, 2010, Marco Martin wrote: > > > >> On Wed, Jul 7, 2010 at 2:23 PM, Thomas

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6434 --- I wouldn't worry about the size just now, it can be done in a separate

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Iamluc
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/ --- (Updated 2010-07-08 19:22:01.397461) Review request for Plasma. Changes --

Re: Review Request: Fix a bogus message indicator item in hidden system tray popup

2010-07-08 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4541/#review6433 --- i actually didn't look at the patch itself, just informed where to sub

Re: Review Request: This patch adds the Storage class for Plasma::DataEngine caching. This current implementation caches to disk. Soon, it will be akonadi.

2010-07-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4548/#review6432 --- Ship it! i did looked at it quite a bit while in branch, i think it's

Review Request: Fix a bogus message indicator item in hidden system tray popup

2010-07-08 Thread Octavian Voicu
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4541/ --- Review request for Plasma. Summary --- Possible fix for a bug in KDE system

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Simon Stiphanos
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? > > Simon Stiphanos

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Simon Stiphanos
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? Hello IamLuc and Be

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Iamluc
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. Thanks you for the review. I don't have an SVN account yet (and I think it's too early to ask one). So could you please commit the patch for me ? - Iamluc -

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Fredrik Höglund
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? > > Simon Stiphanos

Re: kdm-plasma question

2010-07-08 Thread todd rme
On Tue, Jul 6, 2010 at 11:42 AM, Shaun Reich wrote: > So, with kdm-plasma, essentially there is 1 plasmoid which is the > basic "greeter". It's the login dialog that everyone sees on kdm. > > The plasmoid controls a lot of the authentication, and is akin to old > kdm's "plugin system", whereby new

Review Request: This patch adds the Storage class for Plasma::DataEngine caching. This current implementation caches to disk. Soon, it will be akonadi.

2010-07-08 Thread Brian Pritchett
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4548/ --- Review request for Plasma. Summary --- DataEngines can mark or unmark their

Re: initial plasmoid size?

2010-07-08 Thread Thomas Fjellstrom
On July 7, 2010, Thomas Fjellstrom wrote: > On July 7, 2010, Marco Martin wrote: > > On Wed, Jul 7, 2010 at 2:38 PM, Thomas Fjellstrom > > wrote: > > > On July 7, 2010, Marco Martin wrote: > > >> On Wed, Jul 7, 2010 at 2:23 PM, Thomas Fjellstrom > > >> > > > > > > wrote: > > >> > On July 7, 201

Re: [GSoC]: DataEngine queries in JavaScript

2010-07-08 Thread Hayri Bakici
> > is this something that belongs more in a DataEngine, or in a Service? > consider > whether the results will be useful to more than one visualization, whether > a > visualization will want to change the query often (versus them being long- > lived), etc.. so, what do you suggest then? :) _

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Iamluc
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? > > Simon Stiphanos

Re: Fwd: [Bug 207902] launcher support in libtaskmanager

2010-07-08 Thread Anton Kreuzkamp
I'm almost ready so far, but I'm wondering which method the applets use to get the items. (Maybe the problem is in my unclean test-implementation in tasks but TaskGroup::members() doesn't work correct) Thanks in advance for the information best regards, Anton ___

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Beat Wolf
> On 2010-07-08 08:31:35, Beat Wolf wrote: > > Looks good to me, and trunk is open again. > > Iamluc wrote: > Thanks you for the review. > > I don't have an SVN account yet (and I think it's too early to ask one). > So could you please commit the patch for me ? > > Simon Stiphanos

Re: Review Request: Adds support for corner widgets in Plasma::TabBar

2010-07-08 Thread Giulio Camuffo
> On 2010-07-07 20:10:37, Marco Martin wrote: > > i don't think i'm in favor or such a change. > > the tabbar was designed to be something really simple, never to really work > > as complex stuff like a browser tabbar. > > moreover, it's already possible to enable close buttons on the tabs, as

Re: Plasma Calendar showing Akonadi Events in SC 4.5

2010-07-08 Thread Aaron J. Seigo
On July 7, 2010, John Layt wrote: > This becomes a comms issue. If we announce the feature in the release plan > then we will get bug reports for it not working and disappointed users. We > need to either not announce the feature at all, or make it very clear that > this will only work when kdepi

Re: [GSoC]: DataEngine queries in JavaScript

2010-07-08 Thread Aaron J. Seigo
On July 5, 2010, Onur-Hayri Bakici wrote: > I was thinking about the queries that should be used when querying tha > addons since we mostly search for web-media i'll suggest the queries like is this something that belongs more in a DataEngine, or in a Service? consider whether the results will be

Re: Review Request: Folderview : label when empty folder

2010-07-08 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6422 --- Ship it! Looks good to me, and trunk is open again. - Beat On 2010